Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 371597 - Please allow using '@' [at] in filenames, in ${FILESDIR}
Summary: Please allow using '@' [at] in filenames, in ${FILESDIR}
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 11:32 UTC by Michał Górny
Modified: 2011-06-17 03:08 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-06-14 11:32:03 UTC
Right now, repoman disallows files with '@' [at] character in their names. Such a filenames are used by some systemd units, thus it would be great if that character was allowed.

I don't see anything in PMS limiting the characters in AUX files, thus assigning this to qa@.
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-06-14 11:54:44 UTC
I guess the question would be if all the filesystems support properly filenames with that character. Given that we have Gentoo/Alt, NTFS and FAT might be a concern.
Comment 2 Markus Duft (RETIRED) gentoo-dev 2011-06-14 12:38:39 UTC
at least on interix (NTFS), touch "abc@def" works as expected. however i find it very questionable to allow such filenames. IMHO problems on other filesystems, or in strange combinations with some third party portage-tree-crawlers (or whatever) are pre-programmed...
Comment 3 Ulrich Müller gentoo-dev 2011-06-14 14:19:11 UTC
The @ sign is not in the ISO_646.basic:1983 charset, so there might be potential encoding issues. I'd rather avoid such unsafe characters in filenames.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-06-14 17:57:05 UTC
In any case, systemd requires packages to use that character in some unit names. IOW, the packages are going to install such files into the filesystem anyway. The question is whether we'll just keep them like that in ${FILESDIR} or rename during install.
Comment 5 Fabian Groffen gentoo-dev 2011-06-14 18:00:34 UTC
HFS+ has no problem with it either, but I agree with the feeling it is ugly.  I think NFS, AFS and Samba/CIFS should be safe regarding the @ too since they usually rely on the underlying filesystem.
Comment 6 Jonathan Callen (RETIRED) gentoo-dev 2011-06-15 03:37:53 UTC
Windows explicitly allows filenames containing "@" via the Win32 API, so FAT and NTFS are not an issue.
Comment 7 Markus Duft (RETIRED) gentoo-dev 2011-06-15 05:46:39 UTC
although it seem like not beeing an issue regarding filesystems, i have a strong vote against keeping those files with that name in the tree. rather rename them on installing.
Comment 8 SpanKY gentoo-dev 2011-06-17 03:08:06 UTC
(In reply to comment #4)

installing the package is different from syncing the portage tree.  you're free to install those files with those chars, but not store than with those chars in the portage tree.  the filename requirements for the portage tree are much more strict than the install step.

i dont see anyone in favor of this, and it isnt that big of a hassle to require you to use `newins` rather than `doins`, so close it out.