Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 371173 - media-libs/giflib: add USE=static-libs support
Summary: media-libs/giflib: add USE=static-libs support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-11 17:24 UTC by Florian Sowade
Modified: 2011-07-17 22:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (ebuild.diff,576 bytes, patch)
2011-06-11 17:25 UTC, Florian Sowade
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Sowade 2011-06-11 17:24:07 UTC
I cross compile software for a system where I can't use shared libraries using gentoo. Therefor it would be useeful, if --disable-static would only be passed to configure in the giflib ebuild, if the static-libs use flag is not present.

Reproducible: Always
Comment 1 Florian Sowade 2011-06-11 17:25:05 UTC
Created attachment 276687 [details, diff]
proposed patch

A patch for the current giflib ebuild adding the static-libs use flag
Comment 2 SpanKY gentoo-dev 2011-06-12 03:49:16 UTC
ugh, it seems static libs were wrongly punted

Thomas: you cannot indiscriminately disable static libraries.  you must always build both, or add a USE=static-libs flag.  especially without revbumping.
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2011-06-12 11:28:24 UTC
Hmm static-libs useflag added.
I thought none would really need such thing as static libs on imaging library.
(not even other distros provide static lib for this one, and they really provide a lot of them)

@Florian: you don't need to cc yourself on your own bugs as reporter gets the mails anyway :)
Comment 4 SpanKY gentoo-dev 2011-06-16 23:39:19 UTC
other distros doing it wrong doesnt mean we should.  all library packages should be providing static libs (or USE=static-libs).

the latest change isnt quite right yet ... you cant delete .la files when static libs are installed.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-07-03 10:52:55 UTC
Mike, you *can* delete .la files when installing static libraries that have no further dependencies than libc (which is the case with giflib):

http://blog.flameeyes.eu/2009/09/28/removing-la-files-for-dum-w-uncertain-people
Comment 6 SpanKY gentoo-dev 2011-07-03 17:17:19 UTC
except for the part where giflib links against a lot of other libs based on its USE flags
Comment 7 Tomáš Chvátal (RETIRED) gentoo-dev 2011-07-17 22:48:46 UTC
Good point, revbumped.