Bug 371131 – net-misc/tinc-1.0.16 version bump and new feature with keywords

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benda Xu 2011-06-11 09:34:01 UTC]

tinc 1.0.14 is released, please make a version bump:

   http://www.tinc-vpn.org/download/

Besides, tinc supports uml, vde and raw_sockets devices. I have made a patch to reflect this feature.

Reproducible: Always

[Comment 1 Benda Xu 2011-06-11 09:35:22 UTC]

Created attachment 276629 [details, diff]
raw_socket, uml_socket, vde support

raw_socket, uml_socket, vde support

[Comment 2 Benda Xu 2011-06-11 09:37:22 UTC]

Created attachment 276631 [details]
metadata for the new keywords

[Comment 3 Francesco Saverio Proto 2011-06-13 06:56:54 UTC]

The attached patch only removes lines, I think the patch is mangled !

[Comment 4 Benda Xu 2011-06-14 09:18:27 UTC]

Created attachment 276999 [details, diff]
raw_socket, uml_socket, vde support

Sorry, the previous patch was mangled.

[Comment 5 Benda Xu 2011-06-14 09:20:24 UTC]

Created attachment 277001 [details, diff]
raw_socket, uml_socket, vde support

update

[Comment 6 Benda Xu 2011-06-14 09:21:48 UTC]

(In reply to comment #3)
> The attached patch only removes lines, I think the patch is mangled !

Sorry, it was my mistake. Now fixed :)

[Comment 7 Benda Xu 2011-09-02 03:31:32 UTC]

tinc 1.0.16 is released[1]. Plz bump the version directly there.

No maintainer for tinc. Hope I can involve as a developper and take this package sson.

1. http://www.tinc-vpn.org/

[Comment 8 Anthony Basile 2011-09-23 19:14:13 UTC]

(In reply to comment #7)
> tinc 1.0.16 is released[1]. Plz bump the version directly there.
> 
> No maintainer for tinc. Hope I can involve as a developper and take this
> package sson.
> 
> 1. http://www.tinc-vpn.org/

I just took this and bumped 1.0.16 but I didn't apply your patch ... yet.  Let me get a feeling for the package and then I'll add your stuff.

[Comment 9 Benda Xu 2011-12-21 13:28:35 UTC]

(In reply to comment #8)

> I just took this and bumped 1.0.16 but I didn't apply your patch ... yet.  Let
> me get a feeling for the package and then I'll add your stuff.

How does the package feel... till now ;)

[Comment 10 Anthony Basile 2011-12-21 15:32:54 UTC]

(In reply to comment #9)
> (In reply to comment #8)
> 
> > I just took this and bumped 1.0.16 but I didn't apply your patch ... yet.  Let
> > me get a feeling for the package and then I'll add your stuff.
> 
> How does the package feel... till now ;)

Okay I get the hint :)

I'll add you stuff, test, and if it looks good, put it on the tree.  Please test at your end.  It'll be in the tree as tinc-1.0.16-r1.ebuild.

[Comment 11 Anthony Basile 2011-12-21 17:40:29 UTC]

Okay it has been added.  Please test with each of USE="raw", USE="uml" and USE="vde".  Let me know if anything breaks.  Also let me know if you can't test any of the above.

Note the following changes:

1) I renamed "raw_socket" to "raw" and "uml_socket" to "uml" to better fit other local use flag names.

2) The vde code was missing.  Even though it was added before 1.0.14 (but after 1.0.13), Guus forgot to distribute it by adding it to EXTRA_DIST in the Makefile.am.  This has been fixed, but after the 1.0.16 release.  The original patch was against 1.0.13 which never had the vde code.

3) The vde and uml code as it appeared in 1.0.16 had compile time errors, so I back ported the upstream commit which fixed it.

4) I added sanity check to make sure that only one of "raw", "uml" or "vde" is chosen if any one is.

5) tinc is keyworded for arm and sparc which do no have keywording for net-misc/vde, so I had to use mask the flag on those two arches.

I'll wait to hear back from the reporter whether or not everything works before closing.

[Comment 12 Anthony Basile 2011-12-29 16:26:52 UTC]

Okay I'll close this one for now.  Please reopen if there is a problem with these specific changes.

[Comment 13 Benda Xu 2011-12-30 00:04:16 UTC]

Thanks a lot, Anthony. 

Furthermore, tinc-1.0.16-r2 verified to work on amd64-linux, too.