Bug 370873 – mail-client/thunderbird-bin: files/icon/thunderbird-bin-icon.png: binary file in gentoo-x86/

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Matt Turner 2011-06-09 20:19:26 UTC]

./mail-client/thunderbird/files/icon/thunderbird-icon.png
./mail-client/thunderbird/files/icon/thunderbird-icon-unbranded.png
./mail-client/thunderbird-bin/files/icon/thunderbird-bin-icon.png

Binary files like pngs should be distributed via distfiles. CVS (and in the
future, git) don't handle binary files well.

[Comment 1 Matt Turner 2012-01-26 16:56:31 UTC]

Six month ping...

[Comment 2 Nirbheek Chauhan (RETIRED) 2012-01-26 20:38:54 UTC]

(In reply to comment #0)
> ./mail-client/thunderbird/files/icon/thunderbird-icon.png
> ./mail-client/thunderbird/files/icon/thunderbird-icon-unbranded.png
> ./mail-client/thunderbird-bin/files/icon/thunderbird-bin-icon.png
> 
> Binary files like pngs should be distributed via distfiles. CVS (and in the
> future, git) don't handle binary files well.

Isn't this true for just versioned binary files? Those files haven't changed since they were added, and they're smaller than the minimum size. I don't see a problem.

[Comment 3 Samuli Suominen (RETIRED) 2012-02-02 14:36:54 UTC]

(In reply to comment #2)
> (In reply to comment #0)
> > ./mail-client/thunderbird/files/icon/thunderbird-icon.png
> > ./mail-client/thunderbird/files/icon/thunderbird-icon-unbranded.png
> > ./mail-client/thunderbird-bin/files/icon/thunderbird-bin-icon.png
> > 
> > Binary files like pngs should be distributed via distfiles. CVS (and in the
> > future, git) don't handle binary files well.
> 
> Isn't this true for just versioned binary files? Those files haven't changed
> since they were added, and they're smaller than the minimum size. I don't see a
> problem.

If you wish to change the policy, as outlined in 

http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
http://bugs.gentoo.org/show_bug.cgi?id=331331#c2

This bug is not the place, mailing list is

Meanwhile this bug should get fixed like all others in the Tracker

[Comment 4 Nirbheek Chauhan (RETIRED) 2012-02-02 16:56:08 UTC]

(In reply to comment #3)
> If you wish to change the policy, as outlined in 
> 
> http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=2&chap=1
> http://bugs.gentoo.org/show_bug.cgi?id=331331#c2
> 
> This bug is not the place, mailing list is
> 
> Meanwhile this bug should get fixed like all others in the Tracker

My stand on this is: we'll fix this by removing the old icons when the tb/fx icons change. There is zero benefit otherwise, since the file will still be there in CVS history.

(I do not speak for the whole team on this)

[Comment 5 Matt Turner 2012-06-10 18:04:15 UTC]

One year ping...

[Comment 6 Jory A. Pratt 2012-06-10 19:11:16 UTC]

(In reply to comment #5)
> One year ping...

Once we remove tb-3.1* we will clean up files until then not gonna waste time.

[Comment 7 Samuli Suominen (RETIRED) 2012-07-06 07:45:21 UTC]

thunderbird fixed by 3.1 removal, but the problem is still present in thunderbird-bin

[Comment 8 Matt Turner 2012-08-11 18:48:58 UTC]

(In reply to comment #6)
> (In reply to comment #5)
> > One year ping...
> 
> Once we remove tb-3.1* we will clean up files until then not gonna waste
> time.

  12 Feb 2012; Jory A. Pratt <[e-mail]>
  -thunderbird-bin-3.1.12.ebuild, -thunderbird-bin-3.1.16.ebuild,
  -thunderbird-bin-8.0.ebuild, -thunderbird-bin-10.0.ebuild,
  +thunderbird-bin-10.0.1.ebuild:
  Security bump

Hadn't you already removed 3.1 (and thus the need for the icon) at the time you wrote your comment?

Looks like the file can be removed now.

[Comment 9 Matt Turner 2012-09-23 18:45:26 UTC]

(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > One year ping...
> > 
> > Once we remove tb-3.1* we will clean up files until then not gonna waste
> > time.
> 
>   12 Feb 2012; Jory A. Pratt <[e-mail]>
>   -thunderbird-bin-3.1.12.ebuild, -thunderbird-bin-3.1.16.ebuild,
>   -thunderbird-bin-8.0.ebuild, -thunderbird-bin-10.0.ebuild,
>   +thunderbird-bin-10.0.1.ebuild:
>   Security bump
> 
> Hadn't you already removed 3.1 (and thus the need for the icon) at the time
> you wrote your comment?
> 
> Looks like the file can be removed now.

Ping.

[Comment 10 Jeff (JD) Horelick (RETIRED) 2013-04-11 02:29:48 UTC]

fixed in tree for mail-client/thunderbird-bin . Closing.