Bug 370607 – dev-libs/DirectFB-1.4.9: DirectFB-1.4.9-libpng-1.5.patch breaks png support

• Status: VERIFIED FIXED
• Product: Gentoo Linux

[Description Victor Tseng 2011-06-08 06:06:17 UTC]

The patch "DirectFB-1.4.9-libpng-1.5.patch" tries to adopt to libpng-1.5.x, but there's something wrong in the patch so it actually breaks png support instead of fixing it.

The problem sits in these lines:
-     if (setjmp( data->png_ptr->jmpbuf )) {
+     if (png_jmpbuf( data->png_ptr )) {

it should be:
-     if (setjmp( data->png_ptr->jmpbuf )) {
+     if (setjmp( png_jmpbuf( data->png_ptr ) )) {

Reproducible: Always

Steps to Reproduce:
1. emerge DirectFB
2. run some DirectFB apps that loads an PNG file
3. the program fails to load the png file.
Actual Results:  
(!) ImageProvider/PNG: Error reading header!
(!) CreateImageProvider for '/usr/share/LiTE//oben.png' failed
    --> General failure!

Expected Results:  
PNG files loads without the above error

[Comment 1 Agostino Sarubbo 2011-06-08 06:37:29 UTC]

do not add arch team by yourself. Thanks

[Comment 2 Rafał Mużyło 2011-06-08 11:52:34 UTC]

(In reply to comment #1)
> do not add arch team by yourself. Thanks

But on the other hand, reporter seems to be correct.

[Comment 3 Victor Tseng 2011-06-08 15:27:09 UTC]

adding Mike Frysinger <[e-mail]> to CC list, who made the patch according to the ChangeLog.

[Comment 4 SpanKY 2011-06-08 19:13:00 UTC]

thanks, should be fixed with 1.4.9-r1

http://sources.gentoo.org/dev-libs/DirectFB/files/DirectFB-1.4.9-libpng-1.5.patch?r1=1.1&r2=1.2

[Comment 5 Mr. Bones. (RETIRED) 2011-06-10 07:01:13 UTC]

*** Bug 360995 has been marked as a duplicate of this bug. ***