37053 – KDE build fails with ALSA 1.0 (kdelibs)

Bug 37053 - KDE build fails with ALSA 1.0 (kdelibs)

Summary: KDE build fails with ALSA 1.0 (kdelibs)

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] KDE (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-01-02 14:31 UTC by Jake Hamby
Modified:	2004-01-03 17:23 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jake Hamby 2004-01-02 14:31:46 UTC

I've seen this happen with several ebuilds and it is usually pretty easy to patch.  There is a common pattern in ALSA code to check for the newer 0.9.x API with:
 #if (SND_LIB_MAJOR == 0) && (SND_LIB_MINOR == 9)
instead of:
 #if ((SND_LIB_MAJOR == 0) && (SND_LIB_MINOR == 9)) || (SND_LIB_MAJOR >= 1)

In the case of kdelibs, the test is in configure.in.  Here's a patch.



*** configure.in.orig	2003-09-09 18:55:38.000000000 -0700
--- configure.in	2004-01-01 14:02:13.805171166 -0800
***************
*** 1541,1547 ****
        #include <alsa/asoundlib.h>
        #endif
      ],[
!       #if (SND_LIB_MAJOR == 0) && (SND_LIB_MINOR == 9)
          /* we have ALSA 0.9.x */
        #else
          #error not ALSA 0.9.x
--- 1541,1547 ----
        #include <alsa/asoundlib.h>
        #endif
      ],[
!       #if ((SND_LIB_MAJOR == 0) && (SND_LIB_MINOR == 9)) || (SND_LIB_MAJOR >= 1)
          /* we have ALSA 0.9.x */
        #else
          #error not ALSA 0.9.x

Comment 1 Caleb Tennis (RETIRED) gentoo-dev

2004-01-03 17:23:46 UTC

arts and kdelibs have been patched.   thanks for the report.