Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 36997 - quickpkg cannot pack filenames with spaces
Summary: quickpkg cannot pack filenames with spaces
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2004-01-02 00:11 UTC by BigBug
Modified: 2005-01-30 04:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
This solves the described behaviour for me (quickpkg.patch,1005 bytes, patch)
2004-10-22 00:01 UTC, Stefan Illner
Details | Diff
quickpkg-spaces.patch (quickpkg-spaces.patch,1016 bytes, patch)
2004-10-22 22:15 UTC, SpanKY
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BigBug 2004-01-02 00:11:07 UTC
line 58 in /usr/bin/quickpkg
cut -f 2 -d " " ${SRCDIR}/CONTENTS >${MYDIR}/filelist
just print the second field of CONTENTS file (delimeter is space), and will print incorrect result if installed filename contain space[s]

Reproducible: Always
Steps to Reproduce:
1. make .ebuild for fake package which will install filename with spaces
2. emerge it
3. quickpkg packagename

Actual Results:  
.tbz2 not containing this file

Expected Results:  
.tbz2 shoud contain this file
Comment 1 BigBug 2004-04-21 00:29:47 UTC
seems fixed in latest portage versions ;/
Comment 2 Stefan Illner 2004-10-22 00:01:09 UTC
Created attachment 42399 [details, diff]
This solves the described behaviour for me

For me this bug is still present in the very latest version of portage.

# emerge --version
Portage 2.0.51-r2 (default-x86-1.4, gcc-3.3.4, glibc-2.3.4.20040808-r1, 2.6.8.1
i686)

I found the bug when building a package for openoffice, in which the files
under "/usr/share/applnk/OpenOffice.org 1.1/" are missing.

I attached a patch that fixes this issue for me, but as I am not a very skilled
programmer, feel free to improve the code.
Comment 3 Jason Stubbs (RETIRED) gentoo-dev 2004-10-22 07:25:22 UTC
I have to specify a comment. :/
Comment 4 SpanKY gentoo-dev 2004-10-22 22:15:28 UTC
Created attachment 42445 [details, diff]
quickpkg-spaces.patch

try this one out ... worked for me ;)
Comment 5 Stefan Illner 2004-10-31 01:32:11 UTC
Instead of

rm -f ${PORTAGE_TMPDIR}/quickpkglog

the last line, which is not part of the patch, should become

rm -f ${PORTAGE_TMPDIR}/$1-quickpkglog
Comment 6 SpanKY gentoo-dev 2004-10-31 01:39:39 UTC
that last hunk shouldnt even be included, i filed a sep bug a while ago to address that issue
Comment 7 Jason Stubbs (RETIRED) gentoo-dev 2004-11-02 05:24:50 UTC
Included the quickpkglog -> $1-quickpkglog as well, so you can dig that bug up and mark it InCVS too. :)
Comment 8 SpanKY gentoo-dev 2005-01-30 04:03:15 UTC
-r15 has been released