Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 36953 - Default CHOST variable conflicts with comments above it
Summary: Default CHOST variable conflicts with comments above it
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Release Media
Classification: Unclassified
Component: Everything (show other bugs)
Hardware: All Linux
: High minor
Assignee: Daniel Robbins (RETIRED)
URL:
Whiteboard:
Keywords:
: 37707 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-01-01 10:17 UTC by David Marcin
Modified: 2005-03-25 11:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Marcin 2004-01-01 10:17:11 UTC
And I quote (/etc/make.conf included with all stage1 tarballs):
# Host Setting
# ============
#
# If you are using a Pentium Pro or greater processor, leave this line as-is;
# otherwise, change to i586, i486 or i386 as appropriate. All modern systems
# (even Athlons) should use "i686-pc-linux-gnu". All K6's are i586.
#
CHOST="i486-pc-linux-gnu"

End Quote.

Well, it seems to me that, from the second half of the comment, using a P4 I ought to use a CHOST line of "i686-pc-linux-gnu", but the first half of the comment appears to indicate that I should leave the line alone.

Seems to me there's a very easy fix.  Either change it to say:
"If you are using a Pentium Pro or greater processor, change this line to "i686-pc-linux-gnu"" etc, etc.
However, that way seems silly since most new systems will use i686.

The more sensible way in my opinion would probably be to simply change the CHOST variable to:
CHOST="i686-pc-linux-gnu"

Well, either way is good, so long as the comment isnt conflicting with itself :)

Reproducible: Always
Steps to Reproduce:
1. Untar a stage1 tarball
2. View /etc/make.conf included in the tarball
3.
Comment 1 Nicholas Jones (RETIRED) gentoo-dev 2004-01-06 00:15:39 UTC
For next portage releases:

# Host Setting
# ============
#
# Change this line to i586, i486 or i386 as appropriate. All modern systems
# (even Athlons) should use "i686-pc-linux-gnu". All K6's are i586.
#
Comment 2 Nicholas Jones (RETIRED) gentoo-dev 2004-01-06 00:16:12 UTC
Ok... That was slightly off... Not sure why it didn't update the copy buffer:

# Host Setting
# ============
#
# Change this line as appropriate (i686, i586, i486 or i386).
# All modern systems (even Athlons) should use "i686-pc-linux-gnu".
# All K6's are i586.
Comment 3 Brian Harring (RETIRED) gentoo-dev 2004-02-06 13:22:11 UTC
*** Bug 37707 has been marked as a duplicate of this bug. ***
Comment 4 Nicholas Jones (RETIRED) gentoo-dev 2004-04-11 15:30:56 UTC
Added to CVS.
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2005-03-25 11:24:50 UTC
Moving these so we can remove the "Install CD" component from "Gentoo Linux".

I apologize to everyone for this spam, but according to the bugzilla developers,
this is the only reasonable way to do this.