When I put a typo in the MINI_HTTPD_DOCROOT environment variable, it showed it had a badly written init script. * Caching service dependencies ... [ ok ] * Starting mini_httpd ... * MINI_HTTPD_DOCROOT not set correctly in /etc/conf.d/mini_httpd [ !! ] * DO NOT USE EXIT IN INIT.D SCRIPTS * This IS a bug, please fix your broken init.d There is an "exit 1" in the failure of this condition quite obviously. Taking it out I expect will solve it. Reproducible: Always Steps to Reproduce: 1. Set the MINI_HTTPD_DOCROOT variable to something that does not exist 2. /etc/init.d/mini_httpd start Actual Results: Complained about the init script Expected Results: Should abort cleanly.
Are you arguing that the init.d script should sanitise that input? It already correctly bails out when MINI_HTTPD_DOCROOT is not a directory. Changing the Summary accordingly...
I am saying, the script has an "exit 1" in it which should be removed: start() { ebegin "Starting mini_httpd" if [ ! -d "$MINI_HTTPD_DOCROOT" ]; then eend 1 "MINI_HTTPD_DOCROOT not set correctly in /etc/conf.d/mini_httpd" exit 1 # < -- The message says delete this! fi start-stop-daemon --quiet --start --startas /usr/sbin/mini_httpd \ --pidfile /var/run/mini_httpd.pid -- ${MINI_HTTPD_OPTS} eend $? } That is why I marked it as trivial.
openrc team, how are we supposed to make init.d script die properly instead of using "exit 1"? Also, why is "exit 1" not allowed? Thanks for the info
"exit 1" completely aborts the script, which means that the remaining code in /lib/rc/sh/runscript.sh will not be executed; that is why you shouldn't use it. You should always use return instead of exit to exit your service scripts.
Fine, thanks
dropped
