Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 369053 - media-sound/freewheeling fails because of underlinking
Summary: media-sound/freewheeling fails because of underlinking
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard: Pending removal: 2016-02-03
Keywords: PMASKED
Depends on:
Blocks: underlinking
  Show dependency tree
 
Reported: 2011-05-28 16:48 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2016-02-20 17:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (freewheeling-0.6:20110528-113906.log,329.13 KB, text/plain)
2011-05-28 16:48 UTC, Diego Elio Pettenò (RETIRED)
Details
build-fix.patch (build-fix.patch,1.47 KB, patch)
2014-04-16 17:34 UTC, Brian Evans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2011-05-28 16:48:18 UTC
Created attachment 274921 [details]
Build log

Hello there!

You're getting this bug because the package in Summary failed to build in my tinderbox using the gold link editor from binutils. Before closing the bug as INVALID let me explain why this is still important!

The gold link editor does not support underlinking of shared objects, which is something I have described in my blog post:

http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing

Even the basic link editor (ld.bfd) has an option to support this but it is a heck to enable and get passed, so linking with gold is simply quicker.

Fixing underlinking provides optimized --as-needed builds (because the "softer" version no longer need to recover libraries that are underlinked), so it is a Good Thing To Do.

Thank you very much for the attention!
Comment 1 Brian Evans (RETIRED) gentoo-dev 2014-04-16 17:34:04 UTC
Created attachment 375100 [details, diff]
build-fix.patch

Patch to fix underlinking and remove all sed statements from src_prepare
Comment 2 Toralf Förster gentoo-dev 2014-11-29 17:54:55 UTC
failed at my tinderbox too :

This chroot image is located at a hardened amd64 system.

Portage 2.2.14 (python 2.7.8-final-0, default/linux/amd64/13.0, gcc-4.8.3, glibc-2.20, 3.17.4-hardened-r1 x86_64)
=================================================================
System uname: Linux-3.17.4-hardened-r1-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16166892 total,   4299804 free
KiB Swap:   16777212 total,  16777212 free


will try the patch ..
Comment 3 Toralf Förster gentoo-dev 2014-11-30 16:14:36 UTC
The patch seems not to work, I tried this :

src_prepare() {
    sed -i -e 's:-L/usr/X11R6/lib::' configure.ac || die

    sed -i \
        -e '/CFLAGS/s:-g::' \
        -e '/CFLAGS/s:-funroll-loops.*::' \
        -e "s:local/lib/jack:$(get_libdir)/jack:" \
        src/Makefile.am || die

    patch -p1 /etc/portage/patches/media-sound/freewheeling/underlink.patch || die
    eautoreconf
    patch -p1 /etc/portage/patches/media-sound/freewheeling/underlink.patch || die
}

src_configure() {
    econf \
        $(use_enable fluidsynth) \
        --disable-dependency-tracking
    patch -p1 /etc/portage/patches/media-sound/freewheeling/underlink.patch || die
}


but got the same error
OTOH what's about tree-cleaning this ebuild ?
Comment 4 Pacho Ramos gentoo-dev 2016-02-20 17:27:06 UTC
removed