Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 367767 - net-im/imcom: Prepare to use xml.use_pyxml()
Summary: net-im/imcom: Prepare to use xml.use_pyxml()
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Thomas Raschbacher
URL: http://git.stuge.se/?p=imcom.git;a=su...
Whiteboard:
Keywords:
Depends on:
Blocks: xml.use_pyxml
  Show dependency tree
 
Reported: 2011-05-17 17:26 UTC by Arfrever Frehtes Taifersar Arahesis (RETIRED)
Modified: 2015-04-26 12:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-05-17 17:26:27 UTC
This package specifies dependency on dev-python/pyxml.

Please test this package with dev-lang/python-2.7.1-r2:2.7 or >=dev-lang/python-2.7.2_pre20110515:2.7, which require explicit calling of xml.use_pyxml() before using PyXML.

If this package actually needs PyXML, then modify all modules/scripts of this package, which import xml module. The following code should be added before first import of anything from xml module:

import xml
if hasattr(xml, "use_pyxml"):
    xml.use_pyxml()

This code works with previous versions of Python, so no changes in dependencies are needed.
Comment 1 Thomas Raschbacher gentoo-dev 2012-01-29 20:58:57 UTC
I'll have a look, but I am currently considering just removing the whole package from the tree since the maintainer dropped it a long time ago.

Although someone else seems to have picked it back up. I'm trying to contact him now since there haven't been  any updates since 2010..
Comment 2 Peter Stuge 2012-01-29 21:56:01 UTC
(In reply to comment #0)
> This package specifies dependency on dev-python/pyxml.
> 
> Please test this package with dev-lang/python-2.7.1-r2:2.7 or
> >=dev-lang/python-2.7.2_pre20110515:2.7, which require explicit calling of
> xml.use_pyxml() before using PyXML.
> 
> If this package actually needs PyXML, then modify all modules/scripts of this
> package, which import xml module. The following code should be added before
> first import of anything from xml module:
> 
> import xml
> if hasattr(xml, "use_pyxml"):
>     xml.use_pyxml()

New maintainer here. Yes, the code does import xml and use some of the xml module.

The code is at http://git.imcom.im/?p=imcom.git and I'm happy to take patches to fix this.

Thanks!
Comment 3 Arfrever Frehtes Taifersar Arahesis 2012-01-29 21:58:29 UTC
(In reply to comment #2)
> New maintainer here. Yes, the code does import xml and use some of the xml
> module.

Does the code work with only xml module from standard library or does it need PyXML?
Comment 4 Peter Stuge 2012-01-29 22:00:29 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > New maintainer here. Yes, the code does import xml and use some of the xml
> > module.
> 
> Does the code work with only xml module from standard library or does it need
> PyXML?

Dunno. Here's output from git grep xml\.

AccountCreator.py:    from xml.parsers import expat
AccountCreator.py:    from xml.parsers import pyexpat
JabberHandler.py:# from xml.sax.handler import *
JabberHandler.py:# from xml.sax import *
JabberHandler.py:   from   xml.parsers import expat
JabberHandler.py:   from   xml.parsers import pyexpat
LogHandler.py:    from xml.parsers import expat
LogHandler.py:    from xml.parsers import pyexpat
LogHandler.py:            except xml.parsers.expat.error:
Preferences.py:import xml.dom.minidom
Preferences.py:import xml.dom
Preferences.py:          modDomNode = xml.dom.minidom.parseString(amodconfig)
Preferences.py:      prefsDoc = xml.dom.minidom.parse(os.path.join(os.path.expanduser("~"), ".imcom", "imcomrc"))
configure.ac:AC_PY_CHECK_REQUIRED([expat], [xml.parsers])

Does that help in any way?
Comment 5 Arfrever Frehtes Taifersar Arahesis 2012-01-29 22:10:17 UTC
PyXML seems to be not needed.
Comment 6 Peter Stuge 2012-01-30 08:01:32 UTC
(In reply to comment #5)
> PyXML seems to be not needed.

So how to move forward? Would this exclusively be a change in the ebuild, or should there also be some modification upstream?
Comment 7 Arfrever Frehtes Taifersar Arahesis 2012-01-30 14:43:19 UTC
It is sufficient to change ebuilds to depend on Python with "xml" USE flag.
Comment 8 Thomas Raschbacher gentoo-dev 2012-09-06 06:44:28 UTC
I will sort this once I get around to it ;) @Peter thanks for following up on this bug ;) -- on a sidenote do you plan a new release sometime soon? ;)
Comment 9 Peter Stuge 2012-09-06 21:41:56 UTC
(In reply to comment #8)
> on a sidenote do you plan a new release sometime soon? ;)

Nothing planned, but I'm happy to make a new release anytime. Is there something in particular you're looking for in a new release? (Maybe email me directly for further discussion.)
Comment 10 Thomas Raschbacher gentoo-dev 2012-09-17 09:07:06 UTC
@Peter: no that is fine I was just asking so that I don'T just put in current version and then there's a new one a few days later ;)

I expect you are not planning on supporting python3  ^^
Comment 11 Thomas Raschbacher gentoo-dev 2014-05-06 09:41:12 UTC
a link before I loose it again: http://git.stuge.se/?p=imcom.git;a=summary;js=1

(since i might either remove or patch this soon)
Comment 12 Pacho Ramos gentoo-dev 2015-04-26 12:50:33 UTC
dropped