Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 367093 - media-sound/qmidiarp fails with forced --as-needed
Summary: media-sound/qmidiarp fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Sound Team
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 14:24 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2011-05-13 14:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (qmidiarp-0.3.9:20110513-140139.log,690.35 KB, text/plain)
2011-05-13 14:24 UTC, Diego Elio Pettenò (RETIRED)
Details
fix LDFLAGS usage (qmidiarp-0.3.9-ldadd.patch,643 bytes, patch)
2011-05-13 14:40 UTC, Christoph Mende (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2011-05-13 14:24:54 UTC
Created attachment 273065 [details]
Build log

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego
Comment 1 Christoph Mende (RETIRED) gentoo-dev 2011-05-13 14:40:16 UTC
Created attachment 273071 [details, diff]
fix LDFLAGS usage

please test with attached patch, I don't have a forced --as-needed environment to test it.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2011-05-13 14:44:56 UTC
The AM_CPP/CXXFLAGS change looks fishy (or wrong at least); CXXFLAGS are used by the g++ frontend, CPPFLAGS passed to both gcc/g++ for the cpp backend (preprocessor).

But the LDADD change looks right (and it should fail with non-forced --as-needed as well, I just have a template for this anyway).
Comment 3 Christoph Mende (RETIRED) gentoo-dev 2011-05-13 14:48:57 UTC
didn't fail with non-forced as needed here (and didn't warn about ignored LDFLAGS either), but the forced as needed was rather easy to set up, so I committed this already with the CPPFLAGS change. reverted the latter now though, thanks for the catch.