Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 36670 - gauche-gl-0.3.1.ebuild (new)
Summary: gauche-gl-0.3.1.ebuild (new)
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: George Shapovalov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-28 11:13 UTC by Andrei Barbu (RETIRED)
Modified: 2003-12-30 20:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gauche-gl-0.3.1.ebuild (gauche-gl-0.3.1.ebuild,1.25 KB, application/octet-stream)
2003-12-28 11:13 UTC, Andrei Barbu (RETIRED)
Details
destdir-gentoo.diff (destdir-gentoo.diff,2.04 KB, application/octet-stream)
2003-12-28 11:14 UTC, Andrei Barbu (RETIRED)
Details
nvidia-headers-gentoo.diff (nvidia-headers-gentoo.diff,442 bytes, application/octet-stream)
2003-12-28 11:14 UTC, Andrei Barbu (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Barbu (RETIRED) gentoo-dev 2003-12-28 11:13:36 UTC
Hi,

Significant upgrades in gauche-gl, this brings it up to date, and allows it to work with the newest version of gauche.
Comment 1 Andrei Barbu (RETIRED) gentoo-dev 2003-12-28 11:13:59 UTC
Created attachment 22758 [details]
gauche-gl-0.3.1.ebuild
Comment 2 Andrei Barbu (RETIRED) gentoo-dev 2003-12-28 11:14:32 UTC
Created attachment 22759 [details]
destdir-gentoo.diff
Comment 3 Andrei Barbu (RETIRED) gentoo-dev 2003-12-28 11:14:59 UTC
Created attachment 22760 [details]
nvidia-headers-gentoo.diff
Comment 4 George Shapovalov (RETIRED) gentoo-dev 2003-12-30 20:38:45 UTC
Hi Andrei.

Ok, this one had some modifications, which were quite minor actually, but I additionally did a clean-up on the ebuild. You can see the code for what can be done to reduce repetitive parts.
Basically I used base.eclass, which allowed to cut src_unpack and src_compile functions. 

In fact there are multiple ways to do patching. The "automatic" one, allowing to avoid src_unpack is in this ebuild, via use of base eclass. However it does not handle compressed patches (which would be necessary for anything but small and easy fixes. Although this is not that common either, as quite often sed does even better job!).
Another way is to use eutils.eclass. It defines xpatch function, that does automatic determination of patch level and compression used. The downsides are that
1. it isn't integrated with base eclass (so you still need to define src_unpack)
2. It often takes more time, as it need to perform multiple patching trials.

To wrap up the patching theme - it is a policy (that sadly, but expectadly :) has to be enforced every half a year or so) thta everything additional over 2k in size goes onto mirrors instead of FILESDIR.


Of the more significant changes:

1. I put patches directly under files/. From a quick look at them I suspect that they might apply to future versions. If you doubt that we may reverse the change. Still, creating a subdir might be an overkill - it should be sufficient to put version info in the names.

2. I changed /usr/share/${P} to ${PN} in src_install in one place to be more consistent with how it usually is done (and how gouche does it).

The ebuild is in portage already, please test.

George