366241 – dev-vcs/git ebuilds shouldn't set PERL_PATH to "/usr/bin/env perl"

Bug 366241 - dev-vcs/git ebuilds shouldn't set PERL_PATH to "/usr/bin/env perl"

Summary: dev-vcs/git ebuilds shouldn't set PERL_PATH to "/usr/bin/env perl"

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Development (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-06 16:38 UTC by Ian Abbott
Modified:	2011-06-27 19:57 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ian Abbott 2011-05-06 16:38:11 UTC

The current git ebuilds set PERL_PATH="${EPREFIX}/usr/bin/env perl" when invoking emake. Because of this, any git scripts that run perl will use whichever version of perl is found first in the user's PATH, rather than the system-installed version of perl.

A couple of folks on the git mailing list think this is crazy and wrong and it should be a pathname, not a command - see <http://thread.gmane.org/gmane.comp.version-control.git/172973>.

It also breaks git instaweb - see bug 351279 or bug 352693, and may also be breaking the test suite (see the above thread on the git mailing list).

The original "fix" that set this PERL_PATH was for the somewhat obscure bug 326625. Was it really necessary to set PERL_PATH for this fix, or was it sufficient to clear PERL_MM_OPTS?

Reproducible: Always

Comment 1 Robin Johnson archtester

2011-05-07 18:47:14 UTC

I've taken the discussion back to the list.

Comment 2 Robin Johnson archtester

2011-06-27 19:57:12 UTC

Reverted in 1.7.6.