Bug 364511 – media-gfx/raw-thumbnailer-0.2 returns invalid value at exit

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Łukasz Stelmach 2011-04-22 19:15:10 UTC]

Created attachment 270901 [details]
fix the wrong condition check before returning from main()

There is a bug in the source. The condition in the very last if in the main() function is checked wrong way, so when the save_pixbuf returns 0 (success) the whole programme ends with a non-zero return value. This makes other programmes, e.g. Thunar think that the raw-thumbnailer has actually failed. For Thunar in particular this means ignoring the resulting thumbnail.

I have tried to contact upstream but without any success so I've decided to send the patch here.

[Comment 1 Samuli Suominen (RETIRED) 2011-04-22 19:24:25 UTC]

(In reply to comment #0)
> Created attachment 270901 [details]
> fix the wrong condition check before returning from main()
> 
> There is a bug in the source. The condition in the very last if in the main()
> function is checked wrong way, so when the save_pixbuf returns 0 (success) the
> whole programme ends with a non-zero return value. This makes other programmes,
> e.g. Thunar think that the raw-thumbnailer has actually failed. For Thunar in
> particular this means ignoring the resulting thumbnail.
> 
> I have tried to contact upstream but without any success so I've decided to
> send the patch here.

No such thing as =media-gfx/raw-thumbnailer-0.2-r90 in Portage.

Also, I don't see anything ever reported here:

http://code.google.com/p/raw-thumbnailer/issues/list

[Comment 2 Samuli Suominen (RETIRED) 2011-04-22 19:29:02 UTC]

Also since removal of thunar-thumbnailers and replacing it with tumbler, I don't think Thunar or anything in Xfce uses the package at all.

[Comment 3 Samuli Suominen (RETIRED) 2011-04-22 19:50:16 UTC]

Fixed in 0.2-r1  (still no idea where you got -r90 from, so this would show up as an downgrade for you)

+*raw-thumbnailer-0.2-r1 (22 Apr 2011)
+
+  22 Apr 2011; Samuli Suominen <[e-mail]>
+  +raw-thumbnailer-0.2-r1.ebuild,
+  +files/raw-thumbnailer-0.2-return_0_with_success.patch:
+  Return 0 with success wrt #364511 by Łukasz Stelmach.



And please report it to the upstream.   He's very much alive and responsive on googlecode, as he's the same author with ffmpegthumbnailer and I've just dealed with him some weeks ago...

[Comment 4 Samuli Suominen (RETIRED) 2011-04-23 06:26:24 UTC]

http://code.google.com/p/raw-thumbnailer/issues/detail?id=1