Python (vigranumpy) and documentation support in the vigra-1.7.1.ebuild (in official tree) are currently disabled. The cmake files needed for automatic cmake FIND_PACKAGE support are dropped from installation. Reproducible: Always Steps to Reproduce: 1. emerge vigra-1.7.1 Actual Results: no vigra documentation, no python support, no cmake find scripts Expected Results: - documentation in /usr/share/doc/${PF} - cmake scripts in /usr/share/cmake/vigra - python classes in /usr/${libdir}/python2.x/site-packages/vigra/ I reworked the actual ebuild such that the problems described above are fixed. It does build the documentation out-of-source (i.e. in the working directory) instead of mess up the source tree (using the DOCDIR cmake variable).
Created attachment 270505 [details] reworked ebuild with doc generation and python support this ebuild is based on the current vigra-1.7.1 ebuild but adds support for documentation generation, python bindings and does not drop the cmake scripts
Created attachment 270507 [details, diff] use arch-independent cmake-script location This patch changes the install location of cmake scripts. Originally they are installed to /usr/$(libdir)/vigra. This sets the install path to /usr/share/cmake/vigra which is arch/multilib independent. Possible install locations are described here: http://www.cmake.org/cmake/help/cmake-2-8-docs.html#command:find_package
In vigra-1.7.1.ebuild, the cmake scripts are denoted to be useless. These files provide the possibility to find the vigra package automatically in other cmake projects using FIND_PACKAGE(vigra) without caring about writing own cmake find scripts. Packages depending on vigra may rely on this feature since it is the most convenient way to use it. Is there any convention in gentoo where to put these files? There are several locations where cmake looks for such scripts, so perhaps one of the possible directory fits best into gentoo file location conventions. See http://www.cmake.org/cmake/help/cmake-2-8-docs.html#command:find_package for more information.
Created attachment 270509 [details] ebuild with test restriction removed Tests do work, even with python support enabled. There are no hardcoded paths. So this ebuild drops the test restriction.
Just a note, that patch is not using python eclass and as such it wont be accepted to main tree. Also attach your ebuild modifications as diffs not whole ebuilds.
For what goes about the cmake defaults it is new thing starting with cmake-2.8. Most upstreams use FindXXX and require cmake-2.4 and 2.8. I have yet to find some package that use the new way of things but so far installing those files is a bit useless.
Created attachment 272761 [details, diff] New ebuild with python support based on python eclass (In reply to comment #5) > Just a note, that patch is not using python eclass and as such it wont be > accepted to main tree. > > Also attach your ebuild modifications as diffs not whole ebuilds. In this new version of the ebuild, I tried to add python support using the python eclass. Since it is the first time I use it there may still be some errors, in this case, please let me know. Also, using hdf5 with mpi enabled turned out to result in unusable libraries and failing tests, so I restricted usage to non-mpi hdf5 builds. Additionally, I am submitting this ebuild as a diff to the current portage tree version as requested.
Created attachment 281085 [details] vigra-1.7.1.patch The patch is good but the problem i have is that it won't compile for me right now, i get a) oom leak that kills gcc b) undefined vars errors -> i cant patch it. Attaching what i did with it. +- Same what JM did.
Python now added. So both fixed.
