Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 363651 - media-libs/openjpeg-1.4-r1 ebuild without cmake(C++) nor GNU autotools dependency
Summary: media-libs/openjpeg-1.4-r1 ebuild without cmake(C++) nor GNU autotools depend...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-14 23:36 UTC by Sylvain BERTRAND
Modified: 2011-04-20 23:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
bare Makefile based ebuild (openjpeg-1.4-r1.ebuild,1.72 KB, text/plain)
2011-04-14 23:36 UTC, Sylvain BERTRAND
Details
openjpeg-1.4-r1.ebuild.patch (openjpeg-1.4-r1.ebuild.patch,2.16 KB, patch)
2011-04-15 09:56 UTC, Sylvain BERTRAND
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain BERTRAND 2011-04-14 23:36:36 UTC
Created attachment 270001 [details]
bare Makefile based ebuild

Avoid pulling cmake (C++) as a dependency for openjpeg dependent packages
(and GNU autotools). Use the provided Makefile.nix.
Comment 1 SpanKY gentoo-dev 2011-04-15 08:05:59 UTC
use the -e options with sed to combine the multiple replacements into a single call.  and make sure to quote $S.  and post diffs, not entire files.
Comment 2 Sylvain BERTRAND 2011-04-15 09:56:55 UTC
Created attachment 270041 [details, diff]
openjpeg-1.4-r1.ebuild.patch
Comment 3 SpanKY gentoo-dev 2011-04-15 10:15:45 UTC
hmm, i'm not sure sticking -fPIC into common compiler flags is correct.  wont that build the static lib with -fPIC too ?

thinking about it more, what exactly are you trying to fix ?  using autotools is preferable, but using cmake is better than a home grown build system.  this is kind of a step backwards as it means the ebuild is hardcoded to only build on *nix platforms.  Gentoo is evolving to support many many more.
Comment 4 Sylvain BERTRAND 2011-04-15 10:56:09 UTC
It's like that in the provided Makefile.nix. It builds and works for me.

My C++ is jailed in the browser only (=C only system except the browser).
Comment 5 SpanKY gentoo-dev 2011-04-15 16:10:00 UTC
feel free to post an ebuild to use autotools, but i dont think that reasoning is sufficient to convert to raw Makefile
Comment 6 Sylvain BERTRAND 2011-04-15 16:23:15 UTC
I do favor simple build system. The openjpeg provided Makefile.nix is one.

The issue with cmake is the c++ dependency, which does not concern the GNU autotools since it's full C (but way more costly than a bare Makefile).
Comment 7 SpanKY gentoo-dev 2011-04-15 21:03:35 UTC
ive listed a couple of reasons why that isnt acceptable.  i imagine if i read the makefile, i'd find many more problems.

feel free to submit a cmake->autotools patch, but otherwise, nothing to do here.
Comment 8 Sylvain BERTRAND 2011-04-20 23:13:32 UTC
https://gitorious.org/gentoo-overlays/minimal