Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 361103 - Stabilize =net-analyzer/nagios-check_ipmi_sensor-{1.3,2.2}
Summary: Stabilize =net-analyzer/nagios-check_ipmi_sensor-{1.3,2.2}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Ruppert (idl0r)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2011-03-29 12:27 UTC by Christian Ruppert (idl0r)
Modified: 2011-06-12 11:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ruppert (idl0r) gentoo-dev 2011-03-29 12:27:22 UTC
Please stabilize =net-analyzer/nagios-check_ipmi_sensor-1.3 and =net-analyzer/nagios-check_ipmi_sensor-2.2.
Comment 1 Agostino Sarubbo gentoo-dev 2011-03-29 13:35:13 UTC
both version works..

anyway if i have one of two version installed, i can't install the other version. If there's a slot..is expected??
Comment 2 Christian Ruppert (idl0r) gentoo-dev 2011-03-29 13:49:11 UTC
Two different slots because slot 1 needs ipmitool and slot 2 openipmi.
Comment 3 Christoph Mende (RETIRED) gentoo-dev 2011-04-02 08:15:41 UTC
Sounds more like those should be two separate packages. That's not quite what SLOTs were intended for.
Comment 4 David Abbott (RETIRED) gentoo-dev 2011-04-17 15:00:52 UTC
Installed fine on x86, no further testing done.
Comment 5 Rolf Eike Beer archtester 2011-04-18 18:52:18 UTC
I did some testing today using version 2.2 on amd64. Took me like an hour to get it working.

-using the stable version of freeipmi (0.8.9) it doesn't work because the path to ipmimonitoring is wrong (in 0.8.9 it's in /usr/bin, in 1.0.3 it's in /usr/sbin)

-the results were always "critical" for all sensors because the first line of ipmimonitoring output was not ignored. Line 280 needs to be changed to
      if ((NR > 1) && (sensor_status[NR] != "Nominal") && 
(sensor_status[NR] != "N/A")
 to make it work:

eurypon ~ # /usr/lib/nagios/plugins/check_ipmi_sensor -T Fan -v 3 -H localhost
------------- begin of debug output (-v 3 is set): ------------
  script was executed with the following parameters:
    /usr/lib/nagios/plugins/check_ipmi_sensor -T Fan -v 3 -H localhost
  ipmimonitoring version:
    ipmimonitoring - 0.8.9
  ipmimonitoring was executed with the following parameters:
    sudo /usr/bin/ipmimonitoring -g Fan --quiet-cache --sdr-cache-recreate
  ipmimonitoring return code: 0
  output of ipmimonitoring:
ID | Name            | Type | State    | Reading    | Units | Event
16 | Processor 1 FAN | Fan  | Nominal  | 3038.00    | RPM   | 'OK'
17 | System Fan 1    | Fan  | Nominal  | 4080.00    | RPM   | 'OK'
18 | System Fan 2    | Fan  | Nominal  | 3060.00    | RPM   | 'OK'
--------------------- end of debug output ---------------------
Sensor Type 'Fan' Status: OK | 'Name'=Units 'Processor 1 FAN'=RPM 'System Fan 
1'=RPM 'System Fan 2'=RPM 
Processor 1 FAN = RPM (Status: Nominal)
System Fan 1 = RPM (Status: Nominal)
System Fan 2 = RPM (Status: Nominal)

eurypon ~ # /usr/lib/nagios/plugins/check_ipmi_sensor -T Temperature -H 
localhost -v 3
------------- begin of debug output (-v 3 is set): ------------
  script was executed with the following parameters:
    /usr/lib/nagios/plugins/check_ipmi_sensor -T Temperature -H localhost -v 3
  ipmimonitoring version:
    ipmimonitoring - 0.8.9
  ipmimonitoring was executed with the following parameters:
    sudo /usr/bin/ipmimonitoring -g Temperature --quiet-cache --sdr-cache-
recreate
  ipmimonitoring return code: 0
  output of ipmimonitoring:
ID | Name             | Type        | State    | Reading    | Units | Event
13 | Baseboard Temp   | Temperature | Nominal  | 38.00      | C     | 'OK'
14 | IOH Therm Margin | Temperature | Nominal  | -47.00     | C     | 'OK'
15 | Mem P1 Thrm Mrgn | Temperature | Nominal  | -40.00     | C     | 'OK'
19 | P1 Therm Margin  | Temperature | Nominal  | -59.00     | C     | 'OK'
20 | P1 Therm Ctrl %  | Temperature | Nominal  | 0.00       | N/A   | 'OK'
29 | P1 VRD Hot       | Temperature | N/A      | N/A        | N/A   | 'OK'
32 | IOH Therm Trip   | Temperature | N/A      | N/A        | N/A   | 'OK'
--------------------- end of debug output ---------------------
Sensor Type 'Temperature' Status: OK | 'Name'=Reading 'Baseboard Temp'=38.00 
'IOH Therm Margin'=-47.00 'Mem P1 Thrm Mrgn'=-40.00 'P1 Therm Margin'=-59.00 
Baseboard Temp = 38.00 (Status: Nominal)
IOH Therm Margin = -47.00 (Status: Nominal)
Mem P1 Thrm Mrgn = -40.00 (Status: Nominal)
P1 Therm Margin = -59.00 (Status: Nominal)
P1 Therm Ctrl % = 0.00 (Status: Nominal)
P1 VRD Hot = N/A (Status: N/A)
IOH Therm Trip = N/A (Status: N/A)

As you can see in the first output sensor_reading[] and sensor_units[] columns are also exchanged (second output used an already fixed version of the script).

-it would be extremely helpful if the package could install a rule into /etc/sudoers.d to save everyone the time to do it themselves.
Comment 6 Thomas Kahle (RETIRED) gentoo-dev 2011-05-06 08:12:10 UTC
x86 stable. (Can't test.)
Comment 7 Christoph Mende (RETIRED) gentoo-dev 2011-05-11 19:35:39 UTC
amd64 stable
Comment 8 Rolf Eike Beer archtester 2011-05-11 19:57:00 UTC
Just to get that right: you marked that as "everyone can use" with a clear report that the program is totally broken?
Comment 9 Werner Fischer 2011-06-10 10:53:46 UTC
1. Regarding the location problem of ipmimonitoring
   -using the stable version of freeipmi (0.8.9) it doesn't work because the path
   to ipmimonitoring is wrong (in 0.8.9 it's in /usr/bin, in 1.0.3 it's in
   /usr/sbin)

I have now released an updated version of check_ipmi_sensor that queries for the path. I have released it as an release candidate for the first try, can you check whether this works for you with both freeipmi 0.8.9 and 1.0.3 or 1.0.4?
http://www.thomas-krenn.com/en/oss/ipmi-plugin/check_ipmi_sensor_v2.3rc1.tar.gz

2. Regarding the other issue:
   -the results were always "critical" for all sensors because the first line of
   ipmimonitoring output was not ignored. Line 280 needs to be changed to
         if ((NR > 1) && (sensor_status[NR] != "Nominal") && 
   (sensor_status[NR] != "N/A")
    to make it work:
   [...]
   As you can see in the first output sensor_reading[] and sensor_units[] columns
   are also exchanged (second output used an already fixed version of the script).
The output of FreeIPMI depends on the version of FreeIPMI. For recent FreeIPMI releases please use it's legacy output option, e.g. via
./check_ipmi_sensor -H 10.1.102.10 -U monitor -P ***** -L user -O '--legacy-output --interpret-oem-data'
See http://www.thomas-krenn.com/de/wiki/IPMI_Sensor_Monitoring_Plugin#FreeIPMI_Konfiguration_bei_FreeIPMI_0.8..2A_und_neuer for more details.

3. Regarding sudoers:
   -it would be extremely helpful if the package could install a rule into
   /etc/sudoers.d to save everyone the time to do it themselves.
The plugin can also be used via the network, so there can be cases where a sudoers rule is not necessary (e.g. when this Gentoo system is running as a virtual machine somewhere, only monitoring other machines over the network)

Best regards,
Werner
Comment 10 Rolf Eike Beer archtester 2011-06-12 11:32:46 UTC
I do not have access to that machine anymore since I have left that company so I can't test this anymore.

The problems regarding the first line were there both with 0.8.9 and 1.0.[34].