Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 361013 - dev-util/btyacc memory corruption
Summary: dev-util/btyacc memory corruption
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 347133
  Show dependency tree
 
Reported: 2011-03-28 21:49 UTC by William L. Thomson Jr.
Modified: 2011-10-06 08:42 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William L. Thomson Jr. 2011-03-28 21:49:02 UTC
This is causing problems for newer Firebird sources. Looks like its not long enough for the \0 at the end. Minor patch, not worth adding as a patch, or even having as an external patch to the ebuild. Just a simple sed command is enough to resolve problem. Thanks to Adriano dos Santos Fernandes on the firebird-devel@lists.sourceforge.net for the fix, detected using Valgrind. I will see about filing with upstream, but for now want to get this fixed on Gentoo.

diff -Naur btyacc-3.0-r1.ebuild btyacc-3.0-r2.ebuild
--- btyacc-3.0-r1.ebuild	2010-11-18 14:37:08.000000000 -0500
+++ btyacc-3.0-r2.ebuild	2011-03-28 17:26:10.000000000 -0400
@@ -22,6 +22,8 @@
 	cp -av Makefile{,.orig}
 	epatch "${FILESDIR}/${P}-includes.patch"
 	epatch "${FILESDIR}/${P}-makefile.patch"
+	# fix memory issue/glibc corruption
+	sed -i -e "s|len + 13|len + 14|" main.c || die "Could not fix main.c"
 	# Darwin doesn't do static binaries
 	[[ ${CHOST} == *-darwin* ]] && sed -i -e 's/-static//' Makefile
 }
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-29 23:39:15 UTC
Oh wait, that's your mentor?
Comment 2 William L. Thomson Jr. 2011-03-29 23:41:18 UTC
No Patrick has been proxying stuff for me. Which was hilarious that you just change the status on this as I was emailing Mike Frysinger about this very bug. I really don't need a mentor, I was a developer before. I wish the time spent to modify this bug was spent bumping that package. Its a super small fix, and quite obvious what it does :)
Comment 3 Patrick Lauer gentoo-dev 2011-10-06 08:42:08 UTC
+*btyacc-3.0-r2 (06 Oct 2011)
+
+  06 Oct 2011; Patrick Lauer <patrick@gentoo.org> -btyacc-3.0.ebuild,
+  -btyacc-3.0-r1.ebuild, +btyacc-3.0-r2.ebuild, metadata.xml:
+  Fix for #361013, changing metadata to reflect proxy-maintainer
+