360759 – [PATCH] Failed to emerge dev-util/kdevplatform-1.2.0 with USE=kdeenablefinal: several errors

Bug 360759 - [PATCH] Failed to emerge dev-util/kdevplatform-1.2.0 with USE=kdeenablefinal: several errors

Summary: [PATCH] Failed to emerge dev-util/kdevplatform-1.2.0 with USE=kdeenablefinal:...

Status:	RESOLVED WONTFIX

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] KDE (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo KDE team

URL:	https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:	tracking upstream
Keywords:

Depends on:
Blocks:	kdeenablefinal
	Show dependency tree

Reported:	2011-03-27 11:58 UTC by Erik
Modified:	2012-01-17 12:02 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch that fixes the build (kdevplatform-1.2.0-fix_build-1.diff,13.18 KB, patch) 2011-03-27 11:59 UTC, Erik	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Erik 2011-03-27 11:58:38 UTC

dev-util/kdevplatform-1.2.0 fails to build because of several errors

Reproducible: Always

Comment 1 Erik 2011-03-27 11:59:58 UTC

Created attachment 267383 [details, diff]
patch that fixes the build

This patch fixes errors in kdevplatform 1.2.0 so that it can be built:
* Define metatypes in header files and include them instead of having multiple Q_DECLARE_METATYPE(TYPE) for the same TYPE (see http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html).
* Explicit static casts where needed according to the compiler.
* Define urlToData in one place only (a separate new header file).
* Rename one of the functions appendActions to appendContextMenuActions to make the signature unique.
* Add include guard to greputil.h
* Rename one of the structs Visitor to selfAnalysisVisitor to make the identifier unique.
* Use a unique include guard in appendlist_static.h (not the same as in appendlist.h)
* Undefine the macro "mix" after use to not pollute the namespace.

Comment 2 Andreas K. Hüttel archtester

2011-04-12 22:34:10 UTC

Please submit this upstream, it's a pretty big patch. :)

Comment 3 Andreas K. Hüttel archtester

2011-06-13 11:05:32 UTC

Submitted upstream.

Comment 4 Andreas K. Hüttel archtester

2012-01-17 12:02:55 UTC

As per KDE team meeting decision, the kdeenablefinal useflag has been removed.