per the -core discussion, we want a way of easily picking out the commits of new developers. this would make it much easier for existing devs to focus on the new guys to make sure they're picking things up correctly while not being inundated by all the other dev commits. two different ideas to accomplish this (not sure what is easier for infra): - add an X-NewDev e-mail tag to all commit e-mails - send all new dev commits to a dedicated gentoo-commits-nubs list as for figuring out which devs are new, it should be fairly easy with the ldap stuff we already have in place ... just do a query based on their start/return date and add 3 months. this way we wouldnt need someone to manually update said list when people join or are no longer "new".
Webapp removed
this bug is not about the recruiting webapp
oops sorry about that
QA may also be interested in this in order to prevent or fix breakages caused by new developers.
Yes.
Is this something we can implement now with git? Let's say, the new devs needs to have their commits signed of by x "senior" devs before merge?
It's certainly much easier now with git. A new developer's mentor can easily review their commits some command like 'git log --author example@gentoo.org'. It also accepts multiple author arguments, so given a list of new developers (picked from ldap?) it would be easy to create a list of all commits for review.
(In reply to Justin Lecher from comment #6) > Is this something we can implement now with git? Let's say, the new devs > needs to have their commits signed of by x "senior" devs before merge? Are you sure you want this before? 'Before' pretty much sounds like pull request-based workflow. Possibly new dev working on a branch which gets merged to master by mentor, or by himself after review by mentor. As for post-commit monitoring/review, I don't think git/cvs makes much of a difference. The infra for gentoo-commits should suffice. Though I'd personally wouldn't bother adding anything to it for such a small audience. I'd say make mentors follow gentoo-commits@, filtering on 'From' (== committer's e-mail, if I'm not mistaken) and be done with it.
(In reply to Michał Górny from comment #8) that requires everyone to know who the new developers are and to add specific filters for them. the point of this bug is to automatically leverage data infra already has and propagate that out into the lists.
(In reply to SpanKY from comment #9) True, so let's focus on this topic and move the pre-merge review idea elsewhere. So the idea is: * Pull gentooJoin from LDAP and calc diff to now * Pull gentooMentor from LDAP * Send commit diff for all new (<3 month) to mentor and dedicated ml - Should this be done as a post commit hook or as some daily cron job be filtering the repo? - Pulling the info from LDAP every time or daily once? What else?
(In reply to Justin Lecher from comment #10) i'd imagine a cron job or triggered event would run that'd create a cache of new users, and then all runtime hooks would simply consult that. the git e-mails should be fully within our control (as they come from git hooks) which means inserting an X- header in there should be easy, or duplicating to a dedicated mailing list. i don't have a strong opinion on either direction. i suspect just inserting a header will be easiest. i'm not terribly familiar with the boxes/scripts infra is using here though, so my experience on other systems (normal git repos over ssh which trigger e-mails via smtp) might not translate fully.
Almost 7 years have passed, and no effort has been done to implement any of this. Last comment 2 years ago. Closing as WONTFIX. It seems that there is a little real need for this, as filtering commits by user is rather trivial with sieve. Furthermore, the reality proves that old developers need more monitoring than new ones.
