Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 359641 - sys-power/powertop-1.97 depends unconditionally on net-wireless/bluez
Summary: sys-power/powertop-1.97 depends unconditionally on net-wireless/bluez
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 358869
  Show dependency tree
 
Reported: 2011-03-20 18:29 UTC by Vincent-Xavier JUMEL
Modified: 2012-11-22 19:31 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent-Xavier JUMEL 2011-03-20 18:29:55 UTC 
sys-power/powertop should pull net-wireless/bluez only if the bluetooth global useflag is set.

Reproducible: Always

Steps to Reproduce:
1. Install sys-power/powertop

Actual Results:  
net-wireless/bluez is pulled as a dependency

Expected Results:  
net-wireless/bluez should be uninstalled
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-21 02:05:25 UTC 
1.97 and up are not ready for production yet. If you want a tool to tell you how much power hardware and software parts of your system are using, then please downgrade to 1.13.
Comment 2 Nico R. 2011-03-31 08:32:10 UTC 
Well, powertop-1.13 also uses tools from bluez, but does not RDEPEND on net-wireless/bluez. See powertop-1.13/bluetooth.c, lines 96 and 138.

If it is OK in Gentoo not to install the (optional) dependency bluez for powertop-1.13, not installing it should also be OK for powertop-1.97-r1, even if this version is not ready for production yet.

In powertop-1.97-r1, the code does not enable bluetooth support if it is disabled in the kernel. So there is no need to pull in bluez anyway. See powertop-1.97/tuning/bluetooth.cpp, lines 200ff. If the kernel has bluetooth support enabled, but bluez is not installed, the test result will be “Bad”, see the same file, lines 139–142, 163, but that does not harm. Lines 177 and 180 do not even evaluate the exit code, so that does not matter as well.

So there is need to unconditionally pull in bluez even for powertop-1.97. Please change RDEPEND="… net-wireless/bluez …" to RDEPEND="… bluetooth? ( net-wireless/bluez ) …" in the ebuild file. Thanks.
Comment 3 Rick Farina (Zero_Chaos) gentoo-dev 2012-09-10 20:22:21 UTC 
> So there is need to unconditionally pull in bluez even for powertop-1.97.
> Please change RDEPEND="… net-wireless/bluez …" to RDEPEND="… bluetooth? (
> net-wireless/bluez ) …" in the ebuild file. Thanks.

Some people are reporting crashes when bluez isn't installed, others are reporting no issues.  I will amend this dep set if 3 people can test and comment here that they installed powertop-2.1-r1, without bluez installed, and could use it without issue.

Looks like there are three people on the bug already so this should be easy...
Comment 4 Rick Farina (Zero_Chaos) gentoo-dev 2012-09-18 23:29:01 UTC 
Three responses requested, zero received. I will close this bug on Sept 30th 2012 if three people do not confirm bluez is optional and doesn't cause segfault.
Comment 5 Amir Aupov 2012-09-23 08:20:02 UTC 
Rick, I've tested powertop-2.1-r1 (without bluez) for a day, no crashes occured.
Comment 6 Rick Farina (Zero_Chaos) gentoo-dev 2012-11-22 19:31:44 UTC 
Sorry, I am unable to confirm at this time that bluez is optional.