Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 359353 - =net-analyzer/tcpreplay-3.4.4-r1 fails tests with "non-standard" NIC names
Summary: =net-analyzer/tcpreplay-3.4.4-r1 fails tests with "non-standard" NIC names
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-18 12:12 UTC by Thomas Kahle (RETIRED)
Modified: 2014-01-31 13:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log with test failures (build.log,72.39 KB, text/plain)
2011-03-18 12:13 UTC, Thomas Kahle (RETIRED)
Details
Let user define which nic to use (tcpreplay-3.4.4-r1.ebuild.diff,1.19 KB, patch)
2011-03-19 11:17 UTC, Dustin Polke
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Kahle (RETIRED) gentoo-dev 2011-03-18 12:12:51 UTC
As per summary.  Occurred during x86-archtesting for bug 358665.

Reproducible: Always




# emerge --info
Portage 2.1.9.43 (default/linux/x86/10.0/desktop, gcc-4.4.5, glibc-2.11.3-r0, 2.6.34-gentoo-r12 i686)
=================================================================
System uname: Linux-2.6.34-gentoo-r12-i686-Intel-R-_Core-TM-2_Duo_CPU_L7500_@_1.60GHz-with-gentoo-2.0.1
Timestamp of tree: Fri, 18 Mar 2011 08:15:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     4.1_p9
dev-java/java-config: 2.1.11-r3
dev-lang/python:     2.6.6-r2, 3.1.3-r1
dev-util/ccache:     2.4-r9
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.3
sys-apps/sandbox:    2.4
sys-devel/autoconf:  2.13, 2.65-r1
sys-devel/automake:  1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.5
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.36.1 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA nauty PUEL googleearth AdobeFlash-10.1 dlj-1.1 skype-eula IBM-J1.6"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs ccache collision-protect distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms sign splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="http://de-mirror.org/distro/gentoo/ http://linux.rz.ruhr-uni-bochum.de/download/gentoo-mirror/ http://ftp.uni-erlangen.de/pub/mirrors/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LINGUAS="en en_US de ja es fr it"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_EXTRA_OPTS="--timeout=180"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/java-overlay /var/lib/layman/x11 /var/lib/layman/lisp /var/lib/layman/emacs /var/lib/layman/sunrise /home/tom/tom-overlay /home/tom/gentoo/sci"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa anthy apache2 avahi bash-completion berkdb bluetooth branding bzip2 cairo cddb cdparanoia cdr cjk cli consolekit cracklib crypt ctype cups curl cxx daap dbus djvu dri dts dvb dvd dvdr emacs encode exif expat fam fbcon ffmpeg firefox flac fortran ftp gd gdbm gdu gif gimp glut gmp gnome gnome-keyring gnutls gpm graphviz gstreamer gtk guile hal hdaps iconv ieee1394 imagemagick imap imlib ipod ipv6 java javascript jpeg kde latex lcms ldap leim libnotify lm_sensors lzma m17n-lib mad migemo mikmod mime mmx mng modules mp3 mp4 mpeg mplayer mudflap mule musicbrainz mysql mysqli ncurses nls nptl nptlonly nsplugin obex ocaml ogg oggvorbis openal opengl openmp pam pango pcmcia pcre pdf perl php plasma plotutils png policykit ppds pppd python qt3support qt4 readline samba sasl sdl semantic-desktop session slang smartcard spell sqlite sqlite3 sse ssl startup-notification svg sysfs tcpd texlive theora threads tiff tk truetype udev uim unicode usb v4l v4l2 visualization vorbis wicd wifi win32codecs wxwindows x264 x86 xcb xcomposite xft xine xinerama xml xorg xulrunner xv xvid zeroconf zlib zsh-completion" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif so speling status unique_id userdir usertrack vhost_alias" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" DVB_CARDS="usb-dib0700" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_US de ja es fr it" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18 ree18 jruby" USERLAND="GNU" VIDEO_CARDS="intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS
Comment 1 Thomas Kahle (RETIRED) gentoo-dev 2011-03-18 12:13:22 UTC
Created attachment 266357 [details]
build.log with test failures
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-18 17:06:45 UTC
[tcprewrite] Reduce TTL: 			OK
[tcprewrite] TOS test: 				OK
[tcprewrite] MTU Truncate test: 		OK
make[1]: Target `test' not remade because of errors.
make[1]: Leaving directory `/var/tmp/portage/net-analyzer/tcpreplay-3.4.4-r1/work/tcpreplay-3.4.4/test'
make: *** [test] Error 2
 [33;01m*[0m Note, that some tests require eth0 iface to be UP.
[...]

Was it UP?
Comment 3 Thomas Kahle (RETIRED) gentoo-dev 2011-03-18 19:29:03 UTC
(In reply to comment #2)
> [tcprewrite] Reduce TTL:             OK
> [tcprewrite] TOS test:                 OK
> [tcprewrite] MTU Truncate test:         OK
> make[1]: Target `test' not remade because of errors.
> make[1]: Leaving directory
> `/var/tmp/portage/net-analyzer/tcpreplay-3.4.4-r1/work/tcpreplay-3.4.4/test'
> make: *** [test] Error 2
>  [33;01m*[0m Note, that some tests require eth0 iface to be UP.
> [...]
> 
> Was it UP?

For historical reasons I have no eth0, only eth1.  IMHO the test can not assume eth0 to be up.  It also says: 

NOTICE: Tests must be run as root
Comment 4 Dustin Polke 2011-03-19 11:17:19 UTC
Created attachment 266467 [details, diff]
Let user define which nic to use

(In reply to comment #3)
> For historical reasons I have no eth0, only eth1.  IMHO the test can not assume
> eth0 to be up.  It also says: 
> 
> NOTICE: Tests must be run as root
This patch to the ebuild lets the user specify which nic is to be used for tests by setting TCPREPLAY_NIC and TCPREPLAY_NIC2 variables e.g. in make.conf. They default to eth0 which is the current behavior.

Additionally, missing quotes around ${FILESDIR} have been added.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-21 00:59:01 UTC
(In reply to comment #4)
> Created attachment 266467 [details, diff]
> Let user define which nic to use

I can't really tell what file/revision you're patching there.

Also, why not default to lo instead of eth0. lo should be widely available.

Also, downgrading Importance since the test phase output already makes it very clear why it can't succeed. I wonder if this should even block the stabilisation bug, as that's about having a better version stable, and not about petty issues on somebody's test system. Maybe someone else in netmon wants to cut in here?
Comment 6 Thomas Kahle (RETIRED) gentoo-dev 2011-03-21 08:07:51 UTC
(In reply to comment #5)
> (In reply to comment #4)

> Also, downgrading Importance since the test phase output already makes it very
> clear why it can't succeed.

Test phase output can be misleading because you may have patched around things without adjusting the output.  Like mentioned before, it also says "Tests have to be run as root" which 'makes very clear why it can't succeed' (although it does not seem to be the reason).

> I wonder if this should even block the
> stabilisation bug, as that's about having a better version stable

You are right about my 'petty' issues.

Archtesting is a boring procedure and false positives in tests don't make it easier.
Comment 7 Dustin Polke 2011-03-21 08:31:57 UTC
(In reply to comment #5)
> I can't really tell what file/revision you're patching there.
This patch is for tcpreplay-3.4.4-r1.ebuild,v 1.2 2011/03/14 19:18:36 hwoarang

> Also, why not default to lo instead of eth0. lo should be widely available.
I don't know about the test internals. Right now, tests default to eth0, so I made it behave like it was before. If you feel this should be lo, adjust it accordingly. I am not the maintainer, I just proposed a solution that worked for my setup. If you default to lo, you probably can drop the variable stuff because if you have a nic different than eth0 up, you should have lo up as well.


BR,
Dustin
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2014-01-31 13:29:08 UTC
Comment on attachment 266467 [details, diff]
Let user define which nic to use

In the current ebuilds, --with-testnic* is never defined, and I still don't see where this patch would apply. It defaults to eth0 for both nic[12] on Linux systems, which seems fine to me.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2014-01-31 13:32:45 UTC
It probably fails with "predictable network interface names"[1] too.


[1] http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2014-01-31 13:39:55 UTC
I've set it to use =lo in 4.0.2, which should probably work for most people.