Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 358911 - app-office/libreoffice ebuild improvement
Summary: app-office/libreoffice ebuild improvement
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-14 17:45 UTC by Agostino Sarubbo
Modified: 2011-03-14 22:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2011-03-14 17:45:04 UTC
from ebuild:

ewarn " Also if you experience a build break, please make sure to retry "
	ewarn " with MAKEOPTS="-j1" before filing a bug. "
	ewarn

and


make || die "Build failed"

make DESTDIR="${D}" install || die "Installation failed!"


For me is a no-sense because with make the job(s) are set to 1, so remove ewarn or replace make with emake
Comment 1 Andreas Proschofsky (RETIRED) gentoo-dev 2011-03-14 18:35:46 UTC
(In reply to comment #0)
> 
> For me is a no-sense because with make the job(s) are set to 1, so remove ewarn
> or replace make with emake

Huh? Since when? This was never the case (and on my machines parallel make works perfectly with libreoffice), so could you please provide some context.

Also the last time I checked

make DESTDIR="${D}" install

was prefered in ebuilds over emake, but I might recheck on that ;-)
Comment 2 Agostino Sarubbo gentoo-dev 2011-03-14 18:42:27 UTC
nell'ebuild you say MAKEOPTS set to 1 if the build fails, but according to what the ebuild does, the jobs are set to 1

make= 1 job
emake = $makeopts jobs
Comment 3 Agostino Sarubbo gentoo-dev 2011-03-14 18:43:02 UTC
(In reply to comment #2)
> nell'ebuild you say MAKEOPTS set to 1 if the build fails, but according to what
> the ebuild does, the jobs are set to 1
> 
> make= 1 job
> emake = $makeopts jobs

s/nell'/in the
Comment 4 Andreas Proschofsky (RETIRED) gentoo-dev 2011-03-14 18:52:46 UTC
(In reply to comment #2)
> nell'ebuild you say MAKEOPTS set to 1 if the build fails, but according to what
> the ebuild does, the jobs are set to 1
> 
> make= 1 job
> emake = $makeopts jobs

I know what the ebuild says, that was not my question ;-) Anyway I guess this is some sort of misunderstanding you are obviously missing the part that libreoffice has its own configure-flag for parallel build

--with-num-cpus="${JOBS}"

so the info we provide is definitely right, we are using MAKEOPTS to determine hon many jobs we are using. If you are unsure, just check the build log.
Comment 5 Andreas Proschofsky (RETIRED) gentoo-dev 2011-03-14 22:15:08 UTC
As I'm pretty sure I'm right with my last comment: Closing this. Thanks though, good to always rethink stuff.