Created attachment 265477 [details, diff] rxvt-unicode-9.10.ebuild-vanilla.patch Currently USE=vanilla inhibits applying just two patches, whereas this doesn't match the USE flag's description: vanilla - Do not add extra patches which change default behaviour; DO NOT USE THIS ON A GLOBAL SCALE as the severity of the meaning changes drastically I propose we change the ebuild to match this expectation.
I like it. Perhaps we can use REQUIRED_USE to block other use flags when vanilla is enabled? :)
I'd rather just ignore them when USE=vanilla and warn about disabling them or unsetting USE=vanilla to enable them. The effect of REQUIRED_USE would be that emerge simply quits - something we used to have (if use foo && use bar; then die "Disable USE=bar or USE=foo"; fi) and discouraged (for example dev-lang/php with its dozens of USE flags).
True, but that is why we introduced required_use, a way to notify users of conflicting USE flags before starting the emerge run. Anyway, either way is fine by me in this case, +1 for your patch, thanks :)
Committing that in 9.11 with a few tweaks.
@Alex: If you want to put in that REQUIRED_USE, then please do - I have little time right now to look up how to do it, and it would probably improve the upgrade experience.