Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 358269 - x11-terms/rxvt-unicode - USE=vanilla should not apply any patching that does not concern making urxvt run on Gentoo
Summary: x11-terms/rxvt-unicode - USE=vanilla should not apply any patching that does ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Alex Alexander (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 365695
  Show dependency tree
 
Reported: 2011-03-10 18:04 UTC by Jeroen Roovers (RETIRED)
Modified: 2011-05-02 16:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
rxvt-unicode-9.10.ebuild-vanilla.patch (rxvt-unicode-9.10.ebuild-vanilla.patch,3.02 KB, patch)
2011-03-10 18:04 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2011-03-10 18:04:06 UTC
Created attachment 265477 [details, diff]
rxvt-unicode-9.10.ebuild-vanilla.patch

Currently USE=vanilla inhibits applying just two patches, whereas this doesn't match the USE flag's description:

vanilla - Do not add extra patches which change default behaviour; DO NOT USE THIS ON A GLOBAL SCALE as the severity of the meaning changes drastically

I propose we change the ebuild to match this expectation.
Comment 1 Alex Alexander (RETIRED) gentoo-dev 2011-03-25 14:58:49 UTC
I like it. Perhaps we can use REQUIRED_USE to block other use flags when vanilla is enabled? :)
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-25 16:05:40 UTC
I'd rather just ignore them when USE=vanilla and warn about disabling them or unsetting USE=vanilla to enable them.

The effect of REQUIRED_USE would be that emerge simply quits - something we used to have (if use foo && use bar; then die "Disable USE=bar or USE=foo"; fi) and discouraged (for example dev-lang/php with its dozens of USE flags).
Comment 3 Alex Alexander (RETIRED) gentoo-dev 2011-03-26 16:08:24 UTC
True, but that is why we introduced required_use, a way to notify users of conflicting USE flags before starting the emerge run.

Anyway, either way is fine by me in this case, +1 for your patch, thanks :)
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2011-05-02 16:27:42 UTC
Committing that in 9.11 with a few tweaks.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2011-05-02 16:33:17 UTC
@Alex: If you want to put in that REQUIRED_USE, then please do - I have little time right now to look up how to do it, and it would probably improve the upgrade experience.