Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 358217 - mail-client/thunderbird-3.1.9[lightning]: remote calendars won't display
Summary: mail-client/thunderbird-3.1.9[lightning]: remote calendars won't display
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 13:04 UTC by Martin von Gagern
Modified: 2012-01-28 06:34 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (mail-client:thunderbird-3.1.9.emerge--info,7.36 KB, text/plain)
2011-03-10 13:04 UTC, Martin von Gagern
Details
upstream patch modified to apply cleanly (fix_for_webdav.patch,4.03 KB, patch)
2011-03-15 04:29 UTC, Bailey Kong
Details | Diff
ebuild with patch (thunderbird-3.1.9.ebuild,7.70 KB, application/octet-stream)
2011-03-15 04:29 UTC, Bailey Kong
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2011-03-10 13:04:08 UTC
Created attachment 265443 [details]
emerge --info

Current thunderbird with lightning add-on often forgets about my remote calendars. Restarting the app does make them reappear, but simply reloading them doesn't. Web server is a apache with mod_dav running on localhost. The calendars are configured as remote iCal files stored on a http (DAV) server. It seem sthat the first time TB tries an automatic refresh, it gets a "304 Not Modified" response, and incorrectly clears the calendars in response to that.

Steps to Reproduce:
1. Condigure a DAV calendar on an (preferrably unencrypted) HTTP server
2. Open Edit / Preferences / Lightning / General
3. Enable refresh and set the timeout to 1 minute
4. Restart TB
5. Start wireshark
6. Wait a bit over one minute
7. Observe that the Tasks pane in TB is suddenly empty
8. Switch to the Lightning tab, and observe that it is empty as well.
Comment 1 Martin von Gagern 2011-03-10 13:04:57 UTC
6a. observe that wireshark will show you the 304 Not Modified responses
    from the DAV server.
Comment 2 Martin von Gagern 2011-03-11 11:35:33 UTC
Perhaps upstream https://bugzilla.mozilla.org/show_bug.cgi?id=389281 is to blame. There the calendar is cleared whenever the response has length zero, without taking the status code into account.

Reported this upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=640920
Comment 3 Bailey Kong 2011-03-15 04:29:15 UTC
Created attachment 265907 [details, diff]
upstream patch modified to apply cleanly
Comment 4 Bailey Kong 2011-03-15 04:29:44 UTC
Created attachment 265909 [details]
ebuild with patch
Comment 5 Martin von Gagern 2011-03-15 07:30:07 UTC
Instead of the tweaked patch and modified ebuild, the following is enough for users that want the fix before it enters the main portage tree:

# mkdir -p /etc/portage/patches/mail-client/thunderbird-3.1.9
# wget \
  -O /etc/portage/patches/mail-client/thunderbird-3.1.9/fce654340106.patch \
  http://hg.mozilla.org/releases/comm-1.9.2/raw-rev/fce654340106

At least on my system that worked just as well.

A fix in portage would obviously be preferable, though, and for that we do need a modified ebuild. Maintainers might perhaps prefer an ebuild diff. I think the upstream commit is clean enough, as applying its patch generated no error messages for me. Why did you see need for a modification to the patch?
Comment 6 Bailey Kong 2011-03-15 15:09:26 UTC
Hunk #3 didn't apply cleanly for me (manually using the patch command and having portage do it), hence having the need to manually apply the patch then generating the patch I've previously attached.
Comment 7 Bailey Kong 2011-03-15 18:06:41 UTC
You know what, looking back I think my problem was that I applied a different patch from you. I had applied https://bugzilla.mozilla.org/attachment.cgi?id=518903 which I thought was the one to use since it was newer, but wasn't actually the one checked in. So the link you provided in comment #5 is probably the one to actually use.
Comment 8 Martin von Gagern 2011-03-15 21:27:01 UTC
(In reply to comment #7)
> You know what, looking back I think my problem was that I applied a different
> patch from you. I had applied 518903 which I thought was the
> one to use since it was newer, but wasn't actually the one checked in.

That seems to be checked in as 60833e1149eb for comm-central, their main development branch, while my link was to the version backportet to the comm-1.9.2 branch, which corresponds to the thunderbird version in question.
Comment 9 Michael Orlitzky gentoo-dev 2011-05-15 03:41:22 UTC
This is more or less fixed as 3.1.10 doesn't seem to have this problem and is stable on the same arches as 3.1.9.
Comment 10 Nirbheek Chauhan (RETIRED) gentoo-dev 2012-01-28 06:34:44 UTC
Marking as FIXED as per previous comment.