Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 358157 - colo examples wrong after libata migration
Summary: colo examples wrong after libata migration
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs on www.gentoo.org
Classification: Unclassified
Component: Installation Handbook (show other bugs)
Hardware: MIPS Linux
: Normal normal (vote)
Assignee: nm (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 01:55 UTC by Stuart Longland (RETIRED)
Modified: 2011-03-28 11:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes to examples in documentation (fixes.diff,4.16 KB, patch)
2011-03-10 02:08 UTC, Stuart Longland (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Longland (RETIRED) gentoo-dev 2011-03-10 01:55:50 UTC
Not sure when this happened, but I suspect it was a libata related change.

It seems when the documentation was updated, the person doing it just did a:

find /path -type f -name \*.xml | xargs sed -i -e 's/hda/sda/'

which results in the following:

> #:CoLo:#
> mount sda1
> load /kernel.gz.working
> execute root=/dev/sda3 ro console=ttyS0,115200

Similarly for the menu example.  CoLo doesn't know anything about "sda", and so it b0rks.  I discovered this the hard way when I just mindlessly copied and pasted my own example from the documentation.  I am in the midst of doing a CVS check-out now to generate a patch, however the following script should fix this:

find gentoo/xml/htdocs/doc -type f -name hb-install-mips-bootloader.xml \
    | xargs sed -i \
        -e 's/^mount sda/mount hda/' \
        -e 's/Mounting sda/Mounting hda/'
Comment 1 Stuart Longland (RETIRED) gentoo-dev 2011-03-10 02:08:56 UTC
Created attachment 265391 [details, diff]
Fixes to examples in documentation

The aforementioned patch.  Commit at will.
Comment 2 nm (RETIRED) gentoo-dev 2011-03-10 05:34:49 UTC
Not against anything but the English handbook in /doc/en/, please. Translation teams have to roll their own updates; we can't do that for them. Can you split out the changes? Thanks!
Comment 3 Stuart Longland (RETIRED) gentoo-dev 2011-03-10 09:52:49 UTC
(In reply to comment #2)
> Not against anything but the English handbook in /doc/en/, please. Translation
> teams have to roll their own updates; we can't do that for them. Can you split
> out the changes? Thanks!

sed -i  -e 's/^mount sda/mount hda/' \
        -e 's/Mounting sda/Mounting hda/' \
        doc/en/handbook/hb-install-mips-bootloader.xml

I recall we used to do it in bulk; not sure why it'd be different for other languages since I'm not changing the non-English text, just correcting an example configuration file, which is currently wrong regardless of the language.  Anyway, rather than individual patches; the above sed script will patch it regardless of the language.
Comment 4 nm (RETIRED) gentoo-dev 2011-03-23 09:17:18 UTC
Fixed in CVS.

(The only reason why I didn't originally want to do the other languages was because I didn't want to find each one and manually revbump them. I went ahead and did all that anyway, since otherwise people can't install Gentoo on their MIPS boxes. I even included the revbump.)
Comment 5 Jan Kundrát (RETIRED) gentoo-dev 2011-03-28 11:05:06 UTC
(In reply to comment #4)
> (The only reason why I didn't originally want to do the other languages was
> because I didn't want to find each one and manually revbump them. I went ahead
> and did all that anyway, since otherwise people can't install Gentoo on their
> MIPS boxes. I even included the revbump.)

When I did something like that in the past, the issue was indeed finding out which languages were on the last revision already (which means that these only need a revbump + update, where the revbump still needs manual intervention) and which were lagging, because one can't safely touch these.