358059 – cmake-utils.eclass PREFIX is not defined

Bug 358059 - cmake-utils.eclass PREFIX is not defined

Summary: cmake-utils.eclass PREFIX is not defined

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal major (vote)
Assignee:	Gentoo KDE team

URL:
Whiteboard:	[kde overlay]
Keywords:	InOverlay

Depends on:
Blocks:

Reported:	2011-03-09 13:24 UTC by Goran Mekić
Modified:	2012-05-08 21:27 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Define PREFIX (cmake-eutils.patch,2.18 KB, patch) 2011-03-09 13:32 UTC, Goran Mekić	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Goran Mekić 2011-03-09 13:24:06 UTC

While working on https://github.com/mekanix/oomidi-overlay someone noticed that we have a lot of lines like this:
scanelf: rpath_security_checks(): Maybe? sec problem with
DT_RPATH='lib64/oom-2.0beta/modules' in
/var/tmp/portage/media-sound/openoctave-midi-9999/image/usr/bin/oomidi

Defining PREFIX variable sorts this problems (and many others for the oomidi). PREFIX variable is used anyway, I've just defined it early in the cmake-utils.eclass. Here is the patch: http://paste.lugons.org/show/PJ2dFnv0te9nRjiJC0r8/

Reproducible: Always

Comment 1 Goran Mekić 2011-03-09 13:32:38 UTC

Created attachment 265299 [details, diff]
Define PREFIX

Sorry, I've just realized it's the b.g.o practice to attach patches, and not link to them, so here it is.

Comment 2 Andreas K. Hüttel archtester

2011-08-23 21:36:47 UTC

I put this on the agenda for the next KDE meeting; needs to be discussed.

Comment 3 Andreas K. Hüttel archtester

2011-08-31 23:03:47 UTC

Tomas, Maciej - can you please help us with this, does this make sense?

Comment 4 Maciej Mrozowski gentoo-dev

2011-09-02 10:47:48 UTC

Unfortunately Monday is the nearest occasion I'll be able to take a deeper look (especially why this patch fixes issue in question).

I agree though that PREFIX variable handling is a bit inconsistent in cmake-utils and idea itself behind the patch is sound.

Comment 5 Christoph Junghans (RETIRED) gentoo-dev

2012-03-19 04:09:31 UTC

I had a look at the patch, I guess only the CMAKE_INSTALL_LIBDIR needs to be changed. Most of the stuff is in prefix block, so cc'ing prefix.

Comment 6 Andreas K. Hüttel archtester

2012-05-01 20:51:41 UTC

Added this for testing in the KDE overlay, ack'ed by Scarabeus. Will move to the main tree if no breakage occurs.

Comment 7 Andreas K. Hüttel archtester

2012-05-08 21:27:28 UTC

And moved to the main tree.