Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 357823 - media-sound/rhythmbox-0.12.8-r1 fails to compile against libnotify-0.7.1
Summary: media-sound/rhythmbox-0.12.8-r1 fails to compile against libnotify-0.7.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 358033 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-07 19:55 UTC by Javier Pérez
Modified: 2011-04-05 10:53 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to compile against libnotify >=0.7 (rhythmbox-0.12.8-libnotify-0.7.1.patch,1.19 KB, patch)
2011-03-07 20:37 UTC, Javier Pérez
Details | Diff
Fixed patch to compile against libnotify >=0.7 (rhythmbox-0.12.8-libnotify-0.7.1.patch,1.20 KB, patch)
2011-03-07 20:47 UTC, Javier Pérez
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Pérez 2011-03-07 19:55:38 UTC
libnotify-0.7.1 modifies the signature of function notify_notification_new, which makes rhythmbox(amongst other packages) break with the following error:
...
  CC     libstatus_icon_la-rb-status-icon-plugin.lo
rb-status-icon-plugin.c: In function ‘do_notify’:
rb-status-icon-plugin.c:397:3: error: too many arguments to function ‘notify_notification_new’
...

Reproducible: Always

Steps to Reproduce:
1.Update libnotify to at least 0.7.1
2.re emerge rhythmbox
Actual Results:  
Build fails.

Expected Results:  
Build should succeed.
Comment 1 Javier Pérez 2011-03-07 20:37:48 UTC
Created attachment 265073 [details, diff]
Patch to compile against libnotify >=0.7

This patch allows rhythmbox to compile and run with the new libnotify, however I found out that they also removed the possibility to attach the notification to a tray icon.
Perhaps libnotify-0.7.x should stay hard masked until we are further down the road towards GNOME 3?
Comment 2 Javier Pérez 2011-03-07 20:47:51 UTC
Created attachment 265075 [details, diff]
Fixed patch to compile against libnotify >=0.7

I made a mistake on the previous patch, sorry.
Comment 3 Sheldon Hearn 2011-03-08 11:02:34 UTC
This smells like a good candidate for a blocker/tracker bug. There are several packages that have this problem, including

app-crypt/seahorse-plugins
gnome-base/gnome-applets
x11-plugins/compiz-plugins-extra
Comment 4 Ian Abbott 2011-03-08 13:06:00 UTC
The patch in attachment 265075 [details, diff] works for me, thanks.
Comment 5 Albert W. Hopkins 2011-03-09 11:34:08 UTC
I've tried downgrading libnotify, but:

    >=x11-libs/libnotify-0.6.1 required by (sys-apps/gnome-disk-utility-2.32.1::gentoo

And the next-lesser version of libnotify in portage is 0.5.2 (no 0.6 series).
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2011-03-09 14:39:35 UTC
*** Bug 358033 has been marked as a duplicate of this bug. ***
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2011-03-09 15:59:37 UTC
+  09 Mar 2011; Samuli Suominen <ssuominen@gentoo.org>
+  rhythmbox-0.12.8-r1.ebuild, +files/rhythmbox-0.12.8-libnotify-0.7.patch:
+  Fix building with x11-libs/libnotify >= 0.7 wrt #357823 by Javier Pérez.

@gnome herd:

Just for the record:

Compile tested with all except USE=libnotify enabled in rhythmbox. The patch looks fine and nirbheek asked me to handle this.


And thanks Javier.
Comment 8 Juergen Rose 2011-03-09 16:25:39 UTC
The patch in http://bugs.gentoo.org/attachment.cgi?id=265075 works for me too.
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2011-04-05 10:53:34 UTC
*** Bug 358033 has been marked as a duplicate of this bug. ***