Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 357531 - Proper gstreamer support for x11-libs/qt-qt3support
Summary: Proper gstreamer support for x11-libs/qt-qt3support
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
: 379255 387995 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-05 14:18 UTC by Theo Chatzimichos (RETIRED)
Modified: 2012-02-19 16:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qt-qt3support gstreamer fix (qt3support-gstreamer.patch,3.16 KB, patch)
2011-03-05 14:20 UTC, Theo Chatzimichos (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-03-05 14:18:04 UTC
I noticed that qt-qt3support needs media-sound/phonon[gstreamer]. I searched a bit more, and found that what it really needs is -gstreamer when using -phonon in ./configure. I'm sending here a patch for review, if there are no objections i'll commit in a week. (I couldn't resist, I changed the formatting)
Comment 1 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-03-05 14:20:10 UTC
Created attachment 264839 [details, diff]
qt-qt3support gstreamer fix
Comment 2 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-03-05 14:42:02 UTC
my patch is not correct, according to alex we'll need required_use to enable gstreamer use flag when phonon use flag is enabled
Comment 3 Andreas Sturmlechner gentoo-dev 2011-06-16 20:19:35 UTC
oh wow, why is that? just out of curiosity, since I found myself disabling phonon for qt-qt3support because of that.
Comment 4 Jean-Marc Beaune 2011-06-17 11:43:37 UTC
Here qt-qt3support doesn't compile when phonon flag is enabled, anyone interested by emerge log?
Comment 5 Andreas Sturmlechner gentoo-dev 2011-06-17 21:06:00 UTC
This lead me to check for how many packages would actually still depend on qt-qt3support, and oh what a number: 181
Comment 6 Jonathan Callen (RETIRED) gentoo-dev 2011-07-03 22:59:43 UTC
(In reply to comment #5)
> This lead me to check for how many packages would actually still depend on
> qt-qt3support, and oh what a number: 181

Does that include all the packages that inherit kde4-base.eclass (and, by extension kde4-meta.eclass)? Kdelibs still needs qt-qt3support, which means that everything that requires it does too :) .
Comment 7 Davide Pesavento (RETIRED) gentoo-dev 2011-11-18 23:40:53 UTC
*** Bug 379255 has been marked as a duplicate of this bug. ***
Comment 8 Luke-Jr 2011-11-28 01:56:02 UTC
(In reply to comment #6)
> Does that include all the packages that inherit kde4-base.eclass (and, by
> extension kde4-meta.eclass)? Kdelibs still needs qt-qt3support, which means
> that everything that requires it does too :) .

Dependencies should only be direct use. Just because something uses kdelibs doesn't mean something needs qt3support directly...
Comment 9 Davide Pesavento (RETIRED) gentoo-dev 2012-02-18 14:47:37 UTC
qt-qt3support doesn't depend on phonon/gstreamer in any way. Thus I've removed the phonon and kde USE flags from qt3-support-4.8.0-r1.
Comment 10 Ben de Groot 2012-02-19 05:22:59 UTC
(In reply to comment #9)
> qt-qt3support doesn't depend on phonon/gstreamer in any way. Thus I've removed
> the phonon and kde USE flags from qt3-support-4.8.0-r1.

Are you sure that the upstream code changed? We had the phonon useflag in this package to build the phonon configuration dialog for qtconfig. (Yes, this should properly belong to qt-gui, but for some reason this code belongs (belonged?) to the qt3support module...) While I use phonon-vlc myself, I would not want to deprive our users from the phonon-gstreamer configuration dialog in qtconfig, in case they want to use that. And if it is otherwise broken, we should fix it.

I'm reopening this bug to track the issue, as I am planning to test this later, or await others to test it for us.

I will close bug #387995 as a duplicate of this one, and I would like to point interested parties to duplicate bug #379255 for some more discussion/ideas about this issue.
Comment 11 Ben de Groot 2012-02-19 05:24:32 UTC
*** Bug 387995 has been marked as a duplicate of this bug. ***
Comment 12 Markos Chandras (RETIRED) gentoo-dev 2012-02-19 09:28:57 UTC
4.8.0-r1 ebuild is masked as it breaks reverse dependencies (see BLOCKS field)
Comment 13 Davide Pesavento (RETIRED) gentoo-dev 2012-02-19 14:23:26 UTC
qtconfig is built and installed by qt-gui, thus we have to take care of the phonon/gstreamer dependencies there, not in qt3support.

Furthermore, since 4.8, qtconfig no longer depends on qt3support and there are no traces of phonon or gstreamer usage in qt3support code. Have a look at the sources if you don't believe me :)
Comment 14 Markos Chandras (RETIRED) gentoo-dev 2012-02-19 15:28:45 UTC
If this is the case, please do not unmask 4.8.0-r1 because it breaks kde and qtconfig. We need to open a new bug then, to track this issue
Comment 15 Davide Pesavento (RETIRED) gentoo-dev 2012-02-19 16:07:49 UTC
(In reply to comment #14)
> If this is the case, please do not unmask 4.8.0-r1 because it breaks kde and
> qtconfig. We need to open a new bug then, to track this issue

Sure, that's a separate issue (I forgot to check reverse deps) and it is being tracked in bug #404493