Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 357383 - media-sound/easytag-2.1.6: Handle SIGCHLD to make audacious archived skins workable
Summary: media-sound/easytag-2.1.6: Handle SIGCHLD to make audacious archived skins wo...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
: 357385 357387 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-04 15:52 UTC by Alexei Ababilov
Modified: 2013-02-12 11:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix incorrect behavior (easytag-2.1.6-sigchld.patch,1.04 KB, patch)
2011-03-07 10:18 UTC, Alexei Ababilov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Ababilov 2011-03-04 15:52:35 UTC
It seems that development of EasyTAG is stopped, and so I send the patch to gentoo developers.

EasyTAG calls signal(SIGCHLD,SIG_IGN) to avoid zombies. It works fine,
but it leads to one problem.
If one calls 'Run Audio Player', the player's SIGCHLD signal handler is
inherited. So, when audacious calls system() in order to unpack its
archived skin, the archiver process ends silently (the wait() call in
system() function cannot hear that the child process has ended). The
audacious process assumes that there was an error and an unarchived skin
is used.
A possible solution is to set a handler for SIGCHLD in EasyTAG. The
handler is called when a child process ends and the latter doesn't
become a zombie.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-04 15:55:48 UTC
*** Bug 357385 has been marked as a duplicate of this bug. ***
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-04 15:56:29 UTC

*** This bug has been marked as a duplicate of bug 357387 ***
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-04 15:57:29 UTC
oops
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2011-03-04 15:57:43 UTC
*** Bug 357387 has been marked as a duplicate of this bug. ***
Comment 5 Alexei Ababilov 2011-03-07 10:18:16 UTC
Created attachment 265027 [details, diff]
Fix incorrect behavior
Comment 6 David King 2013-02-10 09:58:03 UTC
Alessio's patch has been applied upstream:

http://git.gnome.org/browse/easytag/commit/?id=e84f769cc57d3f33b163ec17107a84c967a98baa
https://mail.gnome.org/archives/easytag-list/2012-December/msg00007.html

and will be in the next EasyTAG release.
Comment 7 David King 2013-02-12 11:14:14 UTC
(In reply to comment #6)
> Alessio's patch has been applied upstream and will be in the next EasyTAG release.

Fixed with the 2.1.8 release that is now in portage.