Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 357097 - kde-misc/kdocker-4.5 desktop icon isn't installed properly
Summary: kde-misc/kdocker-4.5 desktop icon isn't installed properly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-02 15:23 UTC by Agostino Sarubbo
Modified: 2011-06-19 09:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Screenshot (kd.png,22.22 KB, image/png)
2011-03-02 15:24 UTC, Agostino Sarubbo
Details
Fix icon location patch (kdocker-104.patch,392 bytes, patch)
2011-05-31 10:37 UTC, John Schember
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2011-03-02 15:23:18 UTC
$summary

See screenshot.
Comment 1 Agostino Sarubbo gentoo-dev 2011-03-02 15:24:04 UTC
Created attachment 264363 [details]
Screenshot
Comment 2 Agostino Sarubbo gentoo-dev 2011-03-02 15:29:47 UTC
Qt: 4.7.1
KDE Development Platform: 4.6.00 (4.6.0)
Comment 3 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-03-02 15:34:51 UTC
did you try kbuildsycoca4?
Comment 4 Agostino Sarubbo gentoo-dev 2011-03-02 15:40:43 UTC
(In reply to comment #3)
> did you try kbuildsycoca4?
> 

yes..nothing to do
Comment 5 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-03-02 15:58:09 UTC
next step is to check its .desktop file and icon
Comment 6 Agostino Sarubbo gentoo-dev 2011-03-02 16:08:08 UTC
ok, from qlist i see:

/usr/share/kdocker/icons/kdocker.png

a workaround is putting into kdocker a complete path of kdocker png:


#Icon=kdocker
Icon=/usr/share/kdocker/icons/kdocker.png


works here with this method
Comment 7 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2011-03-02 16:51:15 UTC
doesn't seem like a proper fix. my guess is that either the installation dir (/usr/share/kdocker/...) is wrong or that the desktop file doesn't search in that dir while it should
Comment 8 Andreas K. Hüttel archtester gentoo-dev 2011-05-09 20:23:31 UTC
Does this work in kde-4.6.3 ?
Comment 9 Agostino Sarubbo gentoo-dev 2011-05-10 12:28:46 UTC
(In reply to comment #8)
> Does this work in kde-4.6.3 ?

atm i can't test on 4.6.3 but on 4.6.2 does not work
Comment 10 John Schember 2011-05-31 00:12:41 UTC
I am the upstream developer for KDocker.

The kdocker.png should be installed into /usr/share/icons and the line in the .desktop file should say kdocker.png. This is an error with the upstream source. I will be correcting it shortly. However, fixing this issue does not make it into the just released 4.6 release of KDocker.

Also, I do not see this as severe enough of an issue to warrant a special release with just this fix. Releases of KDocker are typically around every 6 months (it's a stable and feature complete project so there isn't much activity other than fixing bugs) so I would suggest this be fixed in the ebuild until it is included in KDocker 4.7.
Comment 11 John Schember 2011-05-31 00:28:15 UTC
Actually the more I think about it. It shouldn't have .png on the icon line. Also, It would be better to put it in /usr/share/pixmaps instead of /usr/share/icons.
Comment 12 John Schember 2011-05-31 10:37:38 UTC
Created attachment 275313 [details, diff]
Fix icon location patch

Here is a patch against revision 104 that puts the icon in /usr/share/pixmaps. This patch should revolve this issue.
Comment 13 Agostino Sarubbo gentoo-dev 2011-05-31 11:05:56 UTC
thanks jonh

It works for me.

@kde team 
Please write on CVS and close as fixed =)

Ty
Comment 14 Agostino Sarubbo gentoo-dev 2011-05-31 11:07:09 UTC
(In reply to comment #13)
> thanks jonh
> 
> It works for me.
> 
> @kde team 
> Please write on CVS and close as fixed =)
> 
> Ty

And bump 4.6 :)
Comment 15 Andreas K. Hüttel archtester gentoo-dev 2011-06-19 09:00:58 UTC
Fixed in 4.6-r1, thanks!