One of the best filemanagers available (gentoo) is about a decade out of data. Since the version in portage (15.6) a major rewrite of the program from scratch has occured. This is in urgent need for an update! Reproducible: Always
Thank you for reporting. 0.19.9 is now in the tree.
--- gentoo-0.19.9.ebuild 22 Feb 2011 19:47:50 -0000 1.1 +++ gentoo-0.19.9.ebuild 23 Feb 2011 15:40:50 -0000 1.2 @@ -1,8 +1,8 @@ # Copyright 1999-2011 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 -# $Header: /var/cvsroot/gentoo-x86/app-misc/gentoo/gentoo-0.19.9.ebuild,v 1.1 2011/02/22 19:47:50 jer Exp $ +# $Header: /var/cvsroot/gentoo-x86/app-misc/gentoo/gentoo-0.19.9.ebuild,v 1.2 2011/02/23 15:40:50 signals Exp $ -EAPI=2 +EAPI=4 inherit eutils @@ -15,10 +15,19 @@ KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86" IUSE="nls" -RDEPEND="x11-libs/gtk+:2" +RDEPEND="x11-libs/gtk+:2 + dev-libs/glib:2 + x11-libs/gdk-pixbuf + x11-libs/pango" DEPEND="${RDEPEND} nls? ( sys-devel/gettext )" I don't get a couple of things here. gtk+ depends on glib so why do you make that explicit? Same for pango : all gtk+ ebuilds in the tree depend on pango already. Also, currently stable gtk+ provides gdk_pixbuf quite nicely: $ !scanelf scanelf -n /usr/bin/gentoo TYPE NEEDED FILE ET_EXEC libgtk-x11-2.0.so.0,libgdk-x11-2.0.so.0,libgio-2.0.so.0,libgdk_pixbuf-2.0.so.0,libpango-1.0.so.0,libgobject-2.0.so.0,libgthread-2.0.so.0,libglib-2.0.so.0,libm.so.6,libpthread.so.0,libc.so.6 /usr/bin/gentoo $ eversion gdk gtk+ * gdk was not found x11-libs/gtk+-2.20.1-r1
(In reply to comment #2) > --- gentoo-0.19.9.ebuild 22 Feb 2011 19:47:50 -0000 1.1 > +++ gentoo-0.19.9.ebuild 23 Feb 2011 15:40:50 -0000 1.2 > @@ -1,8 +1,8 @@ > # Copyright 1999-2011 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > -# $Header: /var/cvsroot/gentoo-x86/app-misc/gentoo/gentoo-0.19.9.ebuild,v 1.1 > 2011/02/22 19:47:50 jer Exp $ > +# $Header: /var/cvsroot/gentoo-x86/app-misc/gentoo/gentoo-0.19.9.ebuild,v 1.2 > 2011/02/23 15:40:50 signals Exp $ > > -EAPI=2 > +EAPI=4 > > inherit eutils > > @@ -15,10 +15,19 @@ > KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86" > IUSE="nls" > > -RDEPEND="x11-libs/gtk+:2" > +RDEPEND="x11-libs/gtk+:2 > + dev-libs/glib:2 > + x11-libs/gdk-pixbuf > + x11-libs/pango" > DEPEND="${RDEPEND} > nls? ( sys-devel/gettext )" > > > I don't get a couple of things here. gtk+ depends on glib so why do you make > that explicit? Same for pango : all gtk+ ebuilds in the tree depend on pango > already. Because it's directly using functions from those libraries, and links against them even with -Wl,--as-needed (as it's supposed to) For example, src/dirpane.c: pango_font_description_free(fdesc); > Also, currently stable gtk+ provides gdk_pixbuf quite nicely: The ebuild is in ~arch too and no need to care about stale gtk+ anymore since arch's are in CC list of the Gnome 2.32 stabilization bug 353436 (from where the split up gdk-pixbuf will go stable too) Might want to read this for long story: http://blog.flameeyes.eu/2009/09/09/proper-dependencies-aren-t-overcomplex
> I don't get a couple of things here. gtk+ depends on glib so why do you make > that explicit? Same for pango : all gtk+ ebuilds in the tree depend on pango > already. > > Also, currently stable gtk+ provides gdk_pixbuf quite nicely: Well, I'm a new dev, so go easy on me if I did something wrong. I didn't mean to overstep my bounds. Also, keep in mind that my mentor was a QA team member, so maybe I've been conditioned to be stricter on these rules than I need to be. ;-) But, it is my understanding that we should not count on a dependency depending on something else. If the software makes direct calls to, say pango, it should be in the DEPENDS. We know now that gtk+ depends on pango, but if that were to change at some point in the future, this ebuild would be broken. To continue to use pango as an example, there are calls to pango functions in lots of the Source files. For example, src/dirpane.c: if(fmt->set_font) { PangoFontDescription *fdesc; if((fdesc = pango_font_description_from_string(fmt->font_name)) != NULL) { gtk_widget_modify_font(dp->view, fdesc); pango_font_description_free(fdesc); } } So it is my understanding that pango needs to be explicitly depended on. Since we are now linking with -Wl,--as-needed, we can generally assume that if it shows up in NEEDED, it was directly called from the program, and not indirectly through a dependency. So, I believe we need to depend on glib, gdk-pixbuf and pango because app-misc/gentoo directly uses functions from each of them.
