Bug 355691 – media-sound/amarok-2.4.0 fails to parse bad DAAP data (patch attached)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Lukas Sandström 2011-02-20 14:00:40 UTC]

The Firefly version installed on my Readynas Duo (Radiator 4.1.7) sends the
aeMK (mediakind) field as an 32 bit int instead of a 8 bit char.

Amarok currently only consumes one byte instead of four, despite the fact that
the field length is correctly reported as four bytes by the server. The
attached patch reworks the DAAP protocol parsing to be more robust.

The patch applies cleanly to amarok-2.4.0.

Reported upstream at https://bugs.kde.org/show_bug.cgi?id=266676

[Comment 1 Lukas Sandström 2011-02-20 14:01:36 UTC]

Created attachment 263165 [details, diff]
Make the DAAP protocol parsing in Amarok more robust.

[Comment 2 Jorge Manuel B. S. Vicetto (RETIRED) 2011-02-22 14:33:18 UTC]

I'm going to wait for the review by the amarok devs before including this patch in amarok.

[Comment 3 Jorge Manuel B. S. Vicetto (RETIRED) 2011-04-20 03:46:56 UTC]

I see the patch was reviewed, but that there was no action in the upstream bug.
I haven't added the patch to amarok-2.4.0.90, but I'll try to poke upstream devs and see if they'll include it before / on amarok-2.4.1.

[Comment 4 Lukas Sandström 2011-06-02 12:04:14 UTC]

The patch is in the upstream repo now.

[Comment 5 Andreas K. Hüttel 2011-06-19 09:06:43 UTC]

The patch will be included in 2.4.2.

[Comment 6 Theo Chatzimichos (RETIRED) 2011-08-01 12:36:24 UTC]

fixed in 2.4.3