Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 355311 - app-portage/layman: Support extra arguments to update commands
Summary: app-portage/layman: Support extra arguments to update commands
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Third-Party Tools (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 10:27 UTC by Dennis Schridde
Modified: 2011-12-03 00:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2011-02-17 10:27:33 UTC
It would be nice if layman.cfg would allow specifying extra arguments to the update commands.

E.g. I patched locally:
--- /usr/lib/python2.6/site-packages/layman/overlays/svn.py.orig        2011-02-17 11:24:52.000000000 +0100
+++ /usr/lib/python2.6/site-packages/layman/overlays/svn.py     2011-02-17 11:25:28.000000000 +0100
@@ -53,6 +53,7 @@
         args = ['co']
         if quiet:
             args.append('-q')
+               args.append('--config-option=config:miscellany:use-commit-times=yes')
         args.append(self.src + '/@')
         args.append(path([base, self.parent.name]))
 
@@ -75,6 +76,7 @@
         args = ['up']
         if quiet:
             args.append('-q')
+               args.append('--config-option=config:miscellany:use-commit-times=yes')
         args.append(checkout_location())
 
         return self.run_command(*args)

Adding this to svn_command in layman.cfg will not work, but result in this error:
* Error was: Program "/usr/bin/svn --config-option=config:miscellany:use-commit-times=yes" not found

Reproducible: Always
Comment 1 Brian Dolbec (RETIRED) gentoo-dev 2011-02-17 22:09:02 UTC
Ok, I've added config options for add and sync operations on a per repo type basis.  There are a few missing in the listing due to the fact they are not possible for that type.  Some others may or may not be possible, but the option to be able to add them was there.  So it is a "user beware" configuration option.

commit http://git.overlays.gentoo.org/gitweb/?p=proj/layman.git;a=commit;h=af55bea519642b9742135498e5fddaececab7d1f

I was unable to test it on all repo types, but the code changes are very simple.  Tested with svn :)
Comment 2 Dennis Schridde 2011-02-18 11:00:06 UTC
Thanks Brian!
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2011-12-03 00:07:36 UTC
Released in >=layman-2.0.0_rc1