Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 353959 - dev-ml/xmlm : Add package
Summary: dev-ml/xmlm : Add package
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High enhancement
Assignee: Default Assignee for New Packages
URL: http://erratique.ch/software/xmlm
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-07 12:59 UTC by Vladimir Ivanov
Modified: 2011-02-21 15:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (xmlm-1.0.2.ebuild,644 bytes, text/plain)
2011-02-07 13:12 UTC, Vladimir Ivanov
Details
ebuild (xmlm-1.0.2.ebuild,697 bytes, text/plain)
2011-02-11 20:35 UTC, Vladimir Ivanov
Details
ebuild (xmlm-1.0.2.ebuild,607 bytes, text/plain)
2011-02-20 22:32 UTC, Vladimir Ivanov
Details
ebuild (xmlm-1.0.2.ebuild,939 bytes, text/plain)
2011-02-21 14:50 UTC, Vladimir Ivanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Ivanov 2011-02-07 12:59:59 UTC
Ocaml XML manipulation module

Reproducible: Always
Comment 1 Vladimir Ivanov 2011-02-07 13:12:02 UTC
Created attachment 261715 [details]
ebuild
Comment 2 Vladimir Ivanov 2011-02-10 16:07:14 UTC
Hi - I want to become proxy-maintainer for the package. How to do that?
Comment 3 Alexis Ballier gentoo-dev 2011-02-11 19:41:59 UTC
the ebuild needs to be improved before reaching the tree:

- please check the license against $PORTDIR/licenses and give it a valid one
- it doesnt need findlib afaik
- please use $P and friends in SRC_URI
- for src_install, INSTALLDIR="${D}/`ocamlc -where`/xmlm" and './build install' should work afaik
- please give it a ocamlopt useflag (and add a requirement on >=dev-lang/ocaml-3.10.2)
- please give it a doc useflag
- add a 'dodoc CHANGES README || die' in src_install too
Comment 4 Vladimir Ivanov 2011-02-11 20:35:12 UTC
Created attachment 262167 [details]
ebuild

- added correct license 
- removed findlib
- didnt add INSTALLDIR="${D}/`ocamlc -where`/xmlm" and './build install' - doesnt work because build script contains mkdir which results in access denied. So i left this part as it was
- added flags
Comment 5 Vladimir Ivanov 2011-02-20 22:32:42 UTC
Created attachment 263219 [details]
ebuild

Did like you said
Comment 6 Alexis Ballier gentoo-dev 2011-02-21 14:03:05 UTC
(In reply to comment #3)
> the ebuild needs to be improved before reaching the tree:
> - please give it a ocamlopt useflag (and add a requirement on
> >=dev-lang/ocaml-3.10.2)

hmm, sorry I wasn't clear on that one:
- you need to depend on >=dev-lang/ocaml-3.10.2[ocamlopt?] to propagate the ocamlopt useflag
- you need to build the native code version if and only if ocamlopt is set, this can be achieved by the module-byte option for the build script in src_compile for building bytecode, and module-native & module-plugin for the native code versions.
in src_install, install-byte for the bytecode version and in addition install + install-plugin if ocamlopt is set.

> - please give it a doc useflag

for the doc useflag I was thinking about installing the files in the doc subdir only if the doc useflag is set. By the way, you should install them with 'dohtml' and not with 'dodoc' as they are html files.
Comment 7 Vladimir Ivanov 2011-02-21 14:50:15 UTC
Created attachment 263289 [details]
ebuild

Alexis, thanks for your reply -- i looked through your several ebuilds and now understand the problem better -- tried to implement what you said in the current ebuild
Comment 8 Alexis Ballier gentoo-dev 2011-02-21 15:03:06 UTC
Added to the tree, thanks. You are listed in metadata.xml, as such you are officially proxy-maintaining it and will receive the bug reports.
For version bumps or any change, you can email me or ml@gentoo.org for getting it committed.

(BTW I did change a little bit your ebuild: enabled ocamlopt by default and some cosmetics in src_install)