Bug 353751 – media-gfx/digikam-1.8.0 fails to build because of a missing default case in the code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description PhobosK 2011-02-05 13:39:12 UTC]

media-gfx/digikam-1.8.0 fails to build with this error:

[ 22%] Building CXX object digikam/CMakeFiles/digikamcore.dir/__/libs/threads/dynamicthread.o
/dev/shm/portage/media-gfx/digikam-1.8.0/work/digikam-1.8.0/libs/threads/dynamicthread.cpp: In member function ‘bool Digikam::DynamicThread::DynamicThreadPriv::transitionToRunning()’:
/dev/shm/portage/media-gfx/digikam-1.8.0/work/digikam-1.8.0/libs/threads/dynamicthread.cpp:261: error: control reaches end of non-void function
make[2]: *** [digikam/CMakeFiles/digikamcore.dir/__/libs/threads/dynamicthread.o] Error 1


because kde-4.6.x seems to default to using -Werror=return-type and there is a missing default case in digikam-1.8.0/libs/threads/dynamicthread.cpp. 

A patch for the ebuild is needed. I upload the one taken from upstream's bugzilla.
It works ok. Please add it to media-gfx/digikam-1.8.0-r1

Reproducible: Always

Steps to Reproduce:
Try emerging media-gfx/digikam-1.8.0.
Actual Results:  
Build failure of media-gfx/digikam-1.8.0


A new ebuild media-gfx/digikam-1.8.0-r1 is needed that adds the patch.

[Comment 1 PhobosK 2011-02-05 13:41:04 UTC]

Created attachment 261578 [details, diff]
A patch for fixing the "control reaches end of non-void function" error when building media-gfx/digikam-1.8.0

[Comment 2 PhobosK 2011-02-05 13:44:12 UTC]

Created attachment 261580 [details]
The actual new ebuild - media-gfx/digikam-1.8.0-r1

[Comment 3 PhobosK 2011-02-05 14:20:42 UTC]

The build fails if gcc <= 4.3.5 is used.
If newer gcc versions are used, there is no problem in building...

[Comment 4 Wormo (RETIRED) 2011-02-05 19:32:58 UTC]

Thanks for submitting your build fix, assigning to digikam maintainers

[Comment 5 Andreas K. Hüttel 2011-02-07 21:25:25 UTC]

Could you please attach your emerge --info for documentation?

I'm always a bit puzzled where the various compile options come from...

[Comment 6 Andreas K. Hüttel 2011-02-07 21:34:26 UTC]

In tree, thanks.