Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 353592 - x11-libs/libfm-0.1.15_pre20110202 should DEPEND on dev-util/gtk-doc
Summary: x11-libs/libfm-0.1.15_pre20110202 should DEPEND on dev-util/gtk-doc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 08:00 UTC by Toei Rei
Modified: 2011-02-16 16:16 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff against libfm-0.1.15_pre20110202.ebuild to make gtk-doc optional (libfm-0.1.15_pre20110202-r1-use-doc.diff,1.37 KB, patch)
2011-02-03 17:11 UTC, tbartdev
Details | Diff
libfm-0.1.15_pre20110202.ebuild (libfm-0.1.15_pre20110202.ebuild,1.58 KB, text/plain)
2011-02-03 17:52 UTC, Helmuth Schmelzer
Details
libfm-0.1.15_pre20110202.ebuild (libfm-0.1.15_pre20110202.ebuild,1.85 KB, text/plain)
2011-02-03 18:24 UTC, Helmuth Schmelzer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toei Rei 2011-02-03 08:00:45 UTC
x11-libs/libfm-0.1.15_pre20110202 fails to compile with "gtkdocize not found" which is found in dev-util/gtk-doc.

Reproducible: Always

Steps to Reproduce:
1. make sure you don't have gtkdocize installed
2. emerge x11-libs/libfm-0.1.15_pre20110202

Actual Results:  
it fails

Expected Results:  
pulling in missing BDEPS and compiling it
Comment 1 Steffen 'j0inty' Stollfuß 2011-02-03 10:18:35 UTC
Hi,

same here on my amd64 box.

The package that is needed is dev-util/gtk-doc.

-----------------------------------------------------------
>>> Emerging (3 of 13) x11-libs/libfm-0.1.15_pre20110202
 * libfm-0.1.15_pre20110202.tar.gz RMD160 SHA1 SHA256 size ;-) ...                                                                                                        [ ok ]
 * Package:    x11-libs/libfm-0.1.15_pre20110202
 * Repository: gentoo
 * Maintainer: hwoarang@gentoo.org lxde@gentoo.org
 * USE:        amd64 elibc_glibc kernel_linux multilib udev userland_GNU
 * FEATURES:   preserve-libs sandbox
>>> Unpacking source...
>>> Unpacking libfm-0.1.15_pre20110202.tar.gz to /var/tmp/portage/x11-libs/libfm-0.1.15_pre20110202/work
>>> Source unpacked in /var/tmp/portage/x11-libs/libfm-0.1.15_pre20110202/work
>>> Preparing source in /var/tmp/portage/x11-libs/libfm-0.1.15_pre20110202/work ...
/var/tmp/portage/x11-libs/libfm-0.1.15_pre20110202/temp/environment: Zeile 2963: gtkdocize: Kommando nicht gefunden.
 * ERROR: x11-libs/libfm-0.1.15_pre20110202 failed:
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line  56:  Called src_prepare
 *   environment, line 2963:  Called die
 * The specific snippet of code:
 *       gtkdocize --copy || die;
----------------------------------------------------------------------

regards
j0inty
Comment 2 tbartdev 2011-02-03 17:09:41 UTC
Same here.
We don't want it to simply work, we want it to be customizable, right?
I don't want to install a whole lot of gnome stuff on an E17 system.

Here goes: doc useflag for libfm.
Comment 3 tbartdev 2011-02-03 17:11:15 UTC
Created attachment 261427 [details, diff]
diff against libfm-0.1.15_pre20110202.ebuild to make gtk-doc optional

Enabling the use flag is actually untested, but it should work..
Comment 4 Helmuth Schmelzer 2011-02-03 17:52:07 UTC
Created attachment 261430 [details]
libfm-0.1.15_pre20110202.ebuild

Corrected version ebuild
Comment 5 tbartdev 2011-02-03 17:55:13 UTC
(In reply to comment #4)
> Created an attachment (id=261430) [details]
> libfm-0.1.15_pre20110202.ebuild
> 
> Corrected version ebuild
> 

In what respect is this ebuild corrected in contrast to the one I sent?
Comment 6 Helmuth Schmelzer 2011-02-03 18:24:22 UTC
Created attachment 261434 [details]
libfm-0.1.15_pre20110202.ebuild

Corrected ebuild, this first correction is obsolete :)
Comment 7 tbartdev 2011-02-03 21:03:44 UTC
(In reply to comment #6)
> Created an attachment (id=261434) [details]
> libfm-0.1.15_pre20110202.ebuild
> 
> Corrected ebuild, this first correction is obsolete :)
> 

I still don't get your point.
You used my changes, but apparently did not apply the patch properly as indenting is wrong with your ebuild. And why do you leave the unnecessary USE statement as well as the gtkdocize line in there? It's of no use (no pun intended) anymore.
If all you want to achieve is posting a new ebuild here (as opposed to posting diffs which are far easier for devs to look through as the changes can easily be spotted) then you should simply apply my diff as in

blackknight ~ # cd /usr/local/portage/x11-libs/libfm/
blackknight libfm # wget "http://bugs.gentoo.org/attachment.cgi?id=261427&action=view" -O - | patch -p0

(provided you have a local copy of the original ebuild in there which I hope you have)
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2011-02-03 23:09:19 UTC
This is already fixed
Comment 9 jakie jia 2011-02-14 16:04:16 UTC
(In reply to comment #8)
> This is already fixed

i see that gtk-doc has been added to the dependence, but the "doc" use is not implemented, right? I personally prefer the doc, since I don't need gtk-doc for anything else except to build the doc for this, which i probably would never need...
Comment 10 tbartdev 2011-02-16 12:45:33 UTC
(In reply to comment #9)
> I personally prefer the doc, since I don't need gtk-doc for
> anything else except to build the doc for this, which i probably would never
> need...

That's what my intent was. And I fully agree with you here.
Markos: Can we please have my patch included?
If not: Do we have to file an extra bug for this/What's the procedure for you to accept the patch?

I think pcmanfm is a fm mostly for people who do NOT use gnome (as those have their own colorful bells and whistles fms packaged with their DE) and/or want a slim DE. This unconditional dependency upon gtk-doc brings a whole *load of packages that are simply unnecessary for I guess 98% of the users (that is, those that do not want to develop stuff with libfm and therefor need its documentation)
This is the list of pkgs that get pulled in on my system w/ my patch and USE="doc" enabled:

blackknight libfm # USE="doc" emerge -1av libfm

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N    ] app-text/scrollkeeper-dtd-1.0  0 kB [0]
[ebuild  N    ] app-text/docbook-sgml-dtd-3.0-r3  0 kB [0]
[ebuild  N    ] app-text/docbook-dsssl-stylesheets-1.79  0 kB [0]
[ebuild  NS   ] app-text/docbook-xml-dtd-4.1.2-r6 [4.3-r1] 74 kB [0]
[ebuild  NS   ] app-text/docbook-xml-dtd-4.2-r2 [4.3-r1] 77 kB [0]
[ebuild  N    ] app-text/rarian-0.8.1-r1  USE="-debug" 0 kB [0]
[ebuild  NS   ] app-text/docbook-xml-dtd-4.4-r2 [4.3-r1] 0 kB [0]
[ebuild  N    ] app-text/gnome-doc-utils-0.20.1  USE="-debug" 0 kB [0]
[ebuild  N    ] app-text/scrollkeeper-9999-r1  0 kB [0]
[ebuild  N    ] app-text/xmlto-0.0.22  USE="-latex" 102 kB [0]
[ebuild  N    ] app-text/opensp-1.5.2-r2  USE="doc nls -static-libs" 0 kB [0]
[ebuild  N    ] app-text/openjade-1.3.2-r3  USE="-static-libs" 0 kB [0]
[ebuild  N    ] dev-util/gtk-doc-1.15-r2  USE="doc -debug -emacs -highlight -test -vim" 0 kB [0]
[ebuild   R   ] x11-libs/libfm-0.1.15_pre20110213-r1  USE="doc* -debug -examples -udev" 0 kB [?=>1]

Total: 14 packages (10 new, 3 in new slots, 1 reinstall), Size of downloads: 253 kB
Portage tree and overlays:
 [0] /usr/portage
 [1] /usr/local/portage
 [?] indicates that the source repository could not be determined


14 packages! And my system works flawlessy without those as well.
Markos, please help us on how to get this into portage.

Thanks in advance and greetings from Austria,
th
Comment 11 Markos Chandras (RETIRED) gentoo-dev 2011-02-16 16:16:33 UTC
Fixed but next time please open a new bug. Thanks for the patch