gcc -O2 -DLINUX -Dlinux -D__KERNEL__ -DMODULE -nostdinc -iwithprefix include -I/var/tmp/portage/svgalib-1.9.17-r3/work/svgalib-1.9.17/kernel/svgalib_helper/include -I. -I/usr/src/linux/include -I/usr/src/linux/include/asm/mach-default -DSVGALIB_HELPER_MAJOR=209 -DMODVERSIONS -include /usr/src/linux/include/linux/modversions.h -M *.c > .depend gcc -O2 -DLINUX -Dlinux -D__KERNEL__ -DMODULE -nostdinc -iwithprefix include -I/var/tmp/portage/svgalib-1.9.17-r3/work/svgalib-1.9.17/kernel/svgalib_helper/include -I. -I/usr/src/linux/include -I/usr/src/linux/include/asm/mach-default -DSVGALIB_HELPER_MAJOR=209 -DMODVERSIONS -include /usr/src/linux/include/linux/modversions.h -c -o main.o main.c In file included from main.c:24: kernel26compat.h:17: error: redefinition of `irqreturn_t' /usr/src/linux/include/linux/interrupt.h:16: error: `irqreturn_t' previously declared here make: *** [main.o] Fehler 1 make: Leaving directory `/var/tmp/portage/svgalib-1.9.17-r3/work/svgalib-1.9.17/kernel/svgalib_helper' !!! ERROR: media-libs/svgalib-1.9.17-r3 failed. !!! Function src_compile, Line 52, Exitcode 2 !!! Failed to build kernel module! Reproducible: Always Steps to Reproduce: 1.emerge svgalib-1.9.17-r1 2. 3. Actual Results: See [Details] Expected Results: emerge correctly Portage 2.0.49-r18 (default-x86-1.4, gcc-3.3.2, glibc-2.3.2-r9, 2.4.22-gentoo-r1 ) ================================================================= System uname: 2.4.22-gentoo-r1 i686 AMD Athlon(tm) Processor Gentoo Base System version 1.4.3.12 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CFLAGS="-march=athlon-tbird -O3 -pipe" CHOST="i686-pc-linux-gnu" COMPILER="gcc3" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.1 /share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/afs/C /etc/afs/afsws /etc/gconf /etc/env.d" CXXFLAGS="-march=athlon-tbird -O3 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs ccache sandbox" GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo ftp://ftp.uni-erla ngen.de/pub/mirrors/gentoo" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="3dnow X afs alsa apm arts avi berkdb cdr crypt cups dvd encode esd foomatic db gdbm gif gpm gtk gtk2 imlib java jpeg kde ldap libg++ libwww mad mikmod motif mpeg ncurses nls oggvorbis opengl oss pam pdflib perl png python qt quicktime r eadline sdl slang spell ssl svga tcltk tcpd truetype usb x86 xml2 xmms xv zlib" btw: I would have reopened bug 21340 if I could btw2: what's the proper product on http://bugs.gentoo.org/enter_bug.cgi?format=guided to enter such bugs for? I'm going to use the ~x86 tree from now on and would like bug reports to go through as smoothly as possible
Odd that svgalib tries to use kernel26compat.h when this isn't a 2.6 kernel. I'd guess whatever tests they employ to determine if kernel26compat.h needs to be included are broken.
Same error on a Pentium4 system, with gentoo-sources-2.4.22-r2 (which is somewhat the standard kernel, isn't it?)
*** Bug 37073 has been marked as a duplicate of this bug. ***
still an issue ? i just built it against vanilla-2.4.23 and gcc-3.3.2
Brian, it's failing because gentoo-sources is not using a standard header. These lines are not in 2.4.22 and there is no way to check for their presence as no unique #define is raised. I'm not really sure what they're doing there, either... This is from the -r4 patch. +/* For 2.6.x compatibility */ +typedef void irqreturn_t; +#define IRQ_NONE +#define IRQ_HANDLED +#define IRQ_RETVAL(x) +
Also fails against 2.4.23-ck1. Grrr, how do these errors make it into the stable release?
plasmaroo: looking that the new kernel26compat.h in the patch and i see this logic: +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,0) + +# ifdef KERNEL_2_6 +# undef KERNEL_2_6 +# endif + +#define my_remap_page_range(vma, start, ofs, len, prot) remap_page_range(start,ofs,len,prot) + +typedef void irqreturn_t; + +#else perhaps we should drop that typedef for irqreturn_t ?
No, that typedef should definitely not be dropped. Otherwise, you break lots of 2.4 kernels. This is fixed in -r5 so I am closing this.
ahh, perhaps you could release -r5 so we 2.4 users can go on? Just updated portage and it seems that -r3 is the latest version in /usr/portage/media-libs/svgalib so even setting ~86 wont get it for us. In the meantime I commented out the patches in -r3, and it builds but I am not sure if I am missing anything important. BillK
Yes, sorry, I meant gentoo-sources-2.4.20-r5...
lo all :) Just wondering whether the svgalib-1.9.17-r5 will be released anytime soon, as this is still keeping my system from being upgraded with an emerge -u world. And an etcat -v svgalib doesn't show a masked r5 either. I think it's weird that this bug is been marked as "fixed" while the r5 version (which is supposed to fix it) hasn't been released yet.
ah ... forgive me for my stupid remark.. should have read through my eyes instead of my ass... Since I am using vanilla sources, I'll open up a new bugreport for this.
# date Mon Feb 16 20:03:22 EST 2004 #emerge -u media-libs/svgalib {snip} gcc -O2 -DLINUX -Dlinux -D__KERNEL__ -DMODULE -nostdinc -iwithprefix include -I/var/tmp/portage/svgalib-1.9.17-r3/work/svgalib-1.9.17/kernel/svgalib_helper/include -I. -I/usr/src/linux/include -I/usr/src/linux/include/asm/mach-default -DSVGALIB_HELPER_MAJOR=209 -DMODVERSIONS -include /usr/src/linux/include/linux/modversions.h -c -o main.o main.c In file included from main.c:24: kernel26compat.h:17: error: redefinition of `irqreturn_t' /usr/src/linux/include/linux/interrupt.h:16: error: `irqreturn_t' previously declared here make: *** [main.o] Error 1 make: Leaving directory `/var/tmp/portage/svgalib-1.9.17-r3/work/svgalib-1.9.17/kernel/svgalib_helper' !!! ERROR: media-libs/svgalib-1.9.17-r3 failed. !!! Function src_compile, Line 59, Exitcode 2 !!! Failed to build kernel module! # ls -l /usr/src/linux lrwxrwxrwx 1 root root 30 Dec 6 12:17 /usr/src/linux -> /usr/src/linux-2.4.23_pre8-gss
I humbly suggest reopening, and I also wanted to add myself to the CC list. :)
