Bug 353464 – media-sound/asunder: version bump (2.1)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Bernd Lommerzheim 2011-02-01 22:50:34 UTC]

Hello,
on 3. Jan 2011 Asunder 2.1 was released. I will attach an ebuild with the following improvements:
* Bump to EAPI="4".
* Simplify dependencies.
* Remove unneeded src_install method.
Best regards.
Bernd Lommerzheim

[Comment 1 Bernd Lommerzheim 2011-02-01 22:51:27 UTC]

Created attachment 261303 [details]
asunder-2.1.ebuild

[Comment 2 Samuli Suominen (RETIRED) 2011-02-01 23:03:09 UTC]

(In reply to comment #0)
> Hello,
> on 3. Jan 2011 Asunder 2.1 was released. I will attach an ebuild with the
> following improvements:

Thanks. :)

> * Bump to EAPI="4".

Unnecessary quoting.

> * Simplify dependencies.

I find COMMON_DEPEND more clear.

> * Remove unneeded src_install method.

It's not unneeded if it installs the documentation AFAIK

[Comment 3 Samuli Suominen (RETIRED) 2011-02-01 23:05:13 UTC]

And configure.in clearly says "libcddb >= 0.9.5"

[Comment 4 Samuli Suominen (RETIRED) 2011-02-01 23:07:42 UTC]

in portage

[Comment 5 Bernd Lommerzheim 2011-02-01 23:43:35 UTC]

I thought (and locally it worked great) that since EAPI 4 there is a default src_install method which installs all these five doc files. And in this case we could remove it from the ebuild? Or did I misunderstood something?
See at http://devmanual.gentoo.org/ebuild-writing/eapi/index.html
And I'm sorry for the wrong libcddb depencency change.

[Comment 6 Tim Harder 2011-02-02 08:20:42 UTC]

(In reply to comment #5)
> I thought (and locally it worked great) that since EAPI 4 there is a default
> src_install method which installs all these five doc files. And in this case we
> could remove it from the ebuild? Or did I misunderstood something?

No, you are correct. If src_install is not defined and the DOCS variable is not defined all those standard doc files will be installed by default when using EAPI 4.