Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 352863 - dev-python/feedparser-5.0.1 should support Python 3
Summary: dev-python/feedparser-5.0.1 should support Python 3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2011-01-26 21:02 UTC by Daniel Robbins
Modified: 2011-03-10 16:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sgmllib-1.0.ebuild - for python-3.x ABIs that no longer offer this. (sgmllib-1.0.ebuild,892 bytes, text/plain)
2011-01-26 21:06 UTC, Daniel Robbins
Details
feedparser-5.0.ebuild - with multiple python ABI support (feedparser-5.0.ebuild,1.16 KB, text/plain)
2011-01-26 21:07 UTC, Daniel Robbins
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Robbins 2011-01-26 21:02:59 UTC
Hello,

I have created an updated ebuild for the new feedparser-5.0 that is now available (released yesterday.) This version of feedparser works with python3 and has lots of bug fixes. It also requires sgmllib (now included with feedparser, was previously part of python2, but not included in python3.)

To address this sgmllib issue -- which could potentially impact other python packages -- I created a new ebuild dev-python/sgmllib-1.0 which will install sgmllib for python-3* ABIs *only* (It does not install anything for python-2* ABIs). This way, multi-ABI python packages that require sgmllib (like this new feedparser) can simply unconditionally depend on dev-python/sgmllib and have this dep satisfied for python-3*, and use the bundled sgmllib for python-2*. This seemed to be the easiest solution to this problem.

Ebuilds attached.
Comment 1 Daniel Robbins 2011-01-26 21:06:27 UTC
Created attachment 260813 [details]
sgmllib-1.0.ebuild - for python-3.x ABIs that no longer offer this.
Comment 2 Daniel Robbins 2011-01-26 21:07:02 UTC
Created attachment 260814 [details]
feedparser-5.0.ebuild - with multiple python ABI support
Comment 3 Daniel Robbins 2011-01-26 21:08:14 UTC
Also note - this is my first time using the python/distutils multiple ABI stuff for ebuilds, so treat accordingly. I did test this under various combinations of python-2.x and 3.x.
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-03-10 01:06:54 UTC
Data of tests partially don't support Python 3. dev-python/feedparser-5.0.1 has about 4370 tests. Test results:
- With Python 2.6: 2 failures
- With Python 2.7: 2 failures
- With Python 3.1: 877 errors
- With Python 3.2: 877 errors
Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-03-10 01:23:58 UTC
Fixed in dev-python/feedparser-5.0.1.
Comment 6 Daniel Robbins 2011-03-10 06:07:58 UTC
Excuse me, what exactly did you "fix" here? You disabled support for python3 in 5.0.1, and did not add the sgmllib ebuild to the tree.

I am following the instructions in the README-PYTHON3 file.

tests pass from the cmdline:

ninja2 feedparser # python3 feedparsertest.py
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 4108 tests in 38.085s

OK
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-03-10 13:50:07 UTC
Support for Python 3 is enabled in dev-python/feedparser-5.0.1. dev-python/feedparser-5.0.1 installs _feedparser_sgmllib.py. All tests with Python 3 are disabled due to large number of errors.
Comment 8 Daniel Robbins 2011-03-10 16:25:00 UTC
Sorry, I was looking at existing 5.0.1 ebuild, not the one you updated yesterday.