Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 352638 - >=net-misc/networkmanager-0.8.2 bug in parsing hostname from dhclient.conf
Summary: >=net-misc/networkmanager-0.8.2 bug in parsing hostname from dhclient.conf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Robert Piasek (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-24 22:37 UTC by Davide Pesavento
Modified: 2011-01-25 02:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Pesavento (RETIRED) gentoo-dev 2011-01-24 22:37:17 UTC 
If dhclient.conf contains the following line
    send host-name "foobar";
the parsed hostname will be: foobar" (yes, with a trailing quote character).

The buggy code is in system-settings/plugins/ifnet/net_utils.c around line 911:
    strip_string (tmp, '"');
    strip_string (tmp, ';');

Basically those two lines need to be swapped, so that the semicolon is _first_ removed and then _both_ quotes are removed.
Comment 1 Mu Qiao (RETIRED) gentoo-dev 2011-01-25 02:48:30 UTC 
Fixed in networkmanager-0.8.2-r4.ebuild. Thanks.