Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 352401 - net-ftp/yafc doesn't handle files > 2GB
Summary: net-ftp/yafc doesn't handle files > 2GB
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Dane Smith (RETIRED)
URL: http://sourceforge.net/tracker/index....
Whiteboard:
Keywords:
Depends on:
Blocks: 355961
  Show dependency tree
 
Reported: 2011-01-22 11:03 UTC by Morse
Modified: 2011-04-29 15:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild to test (yafc-1.1.2.ebuild,1.47 KB, text/plain)
2011-04-05 15:06 UTC, Dane Smith (RETIRED)
Details
New ebuild with temporary tarball (yafc-1.1.1-r1.ebuild,1.57 KB, text/plain)
2011-04-05 20:22 UTC, Carles Pagès
Details
Patch for yafc-1.1.2.ebuild (ebuild.patch,397 bytes, patch)
2011-04-06 18:30 UTC, Carles Pagès
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Morse 2011-01-22 11:03:55 UTC
Yafc can't nor download nor upload large files.

On sourceforge it is suggested that the problem will go, if one compiles yafc with -D_FILE_OFFSET_BITS=64 flag. Perhaps this flag should be added to ebuild.

Reproducible: Always

Steps to Reproduce:
Comment 1 Dane Smith (RETIRED) gentoo-dev 2011-04-04 18:10:19 UTC
This should be fixed in the new 1.1.2 now in Portage. Can we confirm that it is working correctly now before I close it? Thanks!
Comment 2 Morse 2011-04-04 20:27:59 UTC
Ok, this particular bug _seems_ to be fixed. The download has been started, and that is something new.

But this new version is BLOATED with bugs! No help, no autocompletion, no regexp resolving no ANYTHING!

Who released this version anyway? There is no info about a new version on sourceforge page, and new sources are located at github. Is this a fork or what?
Comment 3 Carles Pagès 2011-04-04 21:10:47 UTC
I was the one who commited on github. I sent a mail to the dev ml but have no answers so far of any of the previous devs. I moved to git because it was the only reasonable way I thought of working on the sources. What I certainly don't understand is the problems you're encountering. I'm using it here with no problems.

So, I'll try and see if I can reproduce your problems. Does reverting to the old version still work?
Comment 4 Morse 2011-04-04 22:10:53 UTC
I checked on my working machine: yafc-1.1.2 has indeed some problems. Things i encountered right away:

1. "help" command doesn't list available commands
2. "ls" doesn't list files
3. "tab" doesn't propose a list of possible filenames and doesn't complete it
4. statistics during the download is all wrong (probably because of the wrong "total size")

About the filesize handling - needs some additional testing. It turned out that even the previous version does start the download. And I can't check right now how the program fill behave with several GB file.
Comment 5 Morse 2011-04-04 22:13:07 UTC
Oh, and yes, I checked the 1.1.1-r1. No aforementioned problems present.
Comment 6 Carles Pagès 2011-04-05 07:18:50 UTC
Ok, from that list I can only trigger the help problem. I never use it so it went unnoticed. I'll check that later.

As for big downloads, yafc has never had problems starting them. It stopped when it reached the 2Gb transfer.

The autocompletion issue sounds more like it not properly detecting readline. I removed the eautoreconf step from the ebuild thinking it was no longer needed. Can you try adding that back to the ebuild? I'd try myself, but since I'm unable to reproduce your problems I'm not sure how to test it.
Comment 7 Carles Pagès 2011-04-05 07:24:46 UTC
Ok, it turns out it must be one of the debian patches breaking the help list, since I just tested with a debian machine I have and it's also broken there (version 1.1.1 with their patches).
Comment 8 Morse 2011-04-05 14:59:22 UTC
I checked file of the size about 4.5 GB - downloaded OK without corruption.

But I can't modify ebuild to check what's with readline - never worked with them.
Comment 9 Dane Smith (RETIRED) gentoo-dev 2011-04-05 15:06:23 UTC
Created attachment 268601 [details]
Ebuild to test

This ebuild has the appropriate changes. Give it a try and let me know how it goes please.

(Hackish way to do this)

cp downloaded-ebuild /usr/portage/net-ftp/yafc/
ebuild /usr/portage/net-ftp/yafc/yafc-1.1.2.ebuild manifest
emerge yafc

This will get overwritten the next time you sync and it saves you setting up a local overlay (which would be the proper way to do this =P)
Comment 10 Morse 2011-04-05 15:23:28 UTC
Checked it. No change.

morse@morsebook ~ $ yafc
yafc 1.1.2 Copyright (C) 1998-2001 Martin Hedenfalk <mhe@home.se>.
This program comes with ABSOLUTELY NO WARRANTY; for details type 'warranty'.
This is free software; type 'copyright' for details.

yafc> help
Available commands: (commands may be abbreviated)
yafc> ls
Not connected. Try 'open --help' for more information.
yafc> open *******
Connecting to ********* at port 21...
--------- Welcome to Pure-FTPd [privsep] [TLS] ----------
You are user number 1 of 30 allowed.
Local time is now 18:20. Server port: 21.
IPv6 connections are also welcome on this server.
You will be disconnected after 5 minutes of inactivity.
User ******* OK. Password required
password: 
User ****** has group access to:  *******      
OK. Current restricted directory is /
yafc ***********:/> ls
yafc ***********:/> 

Tried to compile it with USE="-readline". "help" started showing at least something, but "ls" is still empty.
Comment 11 Carles Pagès 2011-04-05 20:22:15 UTC
Created attachment 268631 [details]
New ebuild with temporary tarball

Could you try this new ebuild? Just follow Dane's instructions but replacing the 1.1.1-r1 ebuild. It should download a new tarball with only two patches applied since v1.1.1, one of which for the >2Gb files.

Thanks Dane for your help
Comment 12 Morse 2011-04-06 08:05:39 UTC
No problems found in this one. But I didn't test long files. I don't have any files that I need to down(up)load right now, and my traffic isn't THAT unlimited to just kick several GB around for testing purposes.

May be someone with local ftp-server could do this.
Comment 13 Carles Pagès 2011-04-06 18:30:18 UTC
Created attachment 268751 [details, diff]
Patch for yafc-1.1.2.ebuild

This patch updates the tarball with one that has none of the patches that seem to cause your troubles, but it already has the Gentoo ones applied. Could you do this one more test? Thanks
Comment 14 Morse 2011-04-06 18:47:46 UTC
Yes, looks like it's working.
But again - didn't check it on large files.
Comment 15 Carles Pagès 2011-04-06 21:37:30 UTC
Good.

Dane, can you apply this patch so we have a working version in portage? Thanks!
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2011-04-29 14:10:13 UTC
no longer in tree
Comment 17 Samuli Suominen (RETIRED) gentoo-dev 2011-04-29 15:15:37 UTC
(In reply to comment #16)
> no longer in tree

sorry, that was a mistake.   change status of bug accordingly to TEST-REQUEST (reopen if the problem is still there with 1.1.2)