Bug 35160 – net-analyzer/cnet has hardwired -march=pentium3 CFLAGS

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Eldad Zack (RETIRED) 2003-12-05 16:21:28 UTC]

The -march=pentium3 is set by the patch.
quoting from the patch:

-CFLAGS         = -O -Wall -fPIC $(INCLUDES) $(XINCLUDES)
+CFLAGS         = -march=pentium3 -O3 -pipe -fPIC $(INCLUDES) $(XINCLUDES)

[Comment 1 Eldad Zack (RETIRED) 2003-12-05 16:22:55 UTC]

mmm. It should use portage flags instead of hardwired flags, anyway.

[Comment 2 Eldad Zack (RETIRED) 2003-12-05 17:04:40 UTC]

I've fixed the ebuild to include portage cflags with this in src_unpack:

src_unpack() {
        unpack ${A}
        cd ${S}

        epatch ${FILESDIR}/cnet-2.0.5-gentoo.patch
        sed -e "s/^CFLAGS.*/CFLAGS=${CFLAGS}/" ${S}/src/Makefile.linux > ${S}/src/Makefile.gentoo
        mv ${S}/src/Makefile.gentoo ${S}/src/Makefile.linux
}

but I don't like it - I should use dosed, but dosed uses ${D}.

[Comment 3 Don Seiler (RETIRED) 2003-12-08 13:51:31 UTC]

Adding this in.  Changed the sed line to:

sed -i.orig -e "s/^CFLAGS.*/CFLAGS=${CFLAGS}/" ${S}/src/Makefile.linux

so it just does the backup in place.

Will commit shortly.

[Comment 4 Don Seiler (RETIRED) 2003-12-08 13:56:06 UTC]

Changes committed into portage.  No revision bump.  Re-install cnet-2.0.5 to pick them up.