Bug 35123 – gentoo-sources-2.4.22-r1 LOG_BUF_LEN in include/asm/kmsgdump.h not updated to reflect CONFIG_LOG_BUF_SHIFT option

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jeremy Huddleston (RETIRED) 2003-12-05 03:43:34 UTC]

prinkt.c's LOG_BUF_LEN does get updated based on CONFIG_LOG_BUF_SHIFT, but 
include/asm/kmsgdump.h needs to be updated as well.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Leandro Dorileo (RETIRED) 2003-12-05 12:07:26 UTC]

Created attachment 21756 [details, diff]
patch

take a look if is about it you are talking about...

[Comment 2 Leandro Dorileo (RETIRED) 2003-12-05 13:18:04 UTC]

execuse my english....

Take a look if it (atached file) is what you are talking about....

[Comment 3 Jeremy Huddleston (RETIRED) 2003-12-05 14:48:00 UTC]

Created attachment 21763 [details, diff]
patch

Actually, I was thinking more like this...

We need to linux/config.h to actually get access to those macros, so it kinda
makes the header a bit ugly, but it needs to have the same value as in
printk.c...

[Comment 4 Tim Yamin (RETIRED) 2003-12-05 15:55:55 UTC]

In CVS in gentoo-sources-2.4.22-r1; just remerge it and the patch is in. Brian, can you please sort this out at your end for the next release?

[Comment 5 Brian Jackson (RETIRED) 2003-12-10 12:14:08 UTC]

Okay, I talked to willy about this, and he says, the second patch is okay. He doesn't like the code duplication, but there's not much to do about that without moving the #define from printk.c to a common header. I've fixed this in the local tree, so it'll be in the rest of the gentoo-sources. Thanks for the help.