Bug 35109 – cnet-2.0.5 ebuild: Installing documentation and examples.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description viktor 2003-12-04 19:22:50 UTC]

# Copyright 1999-2003 Gentoo Technologies, Inc.
# Distributed under the terms of the GNU General Public License v2
# $Header: /usr/local/portage/net-analyzer/cnet/RCS/cnet-2.0.5-r1.ebuild,v 1.1
2003/12/05 02:07:44 root Exp $


S=${WORKDIR}/cnet-2.0.5
DESCRIPTION="Network simulation tool"
HOMEPAGE="http://www.csse.uwa.edu.au/cnet"
SRC_URI="http://www.csse.uwa.edu.au/cnet/${P}.tgz"
LICENSE="GPL-2"
SLOT="0"
KEYWORDS="~x86"
IUSE=""
DEPEND=">=dev-lang/tk-8.3.4"
RDEPEND=">=dev-lang/tk-8.3.4"

src_unpack() {
	unpack ${A}
	cd ${S}

	epatch ${FILESDIR}/cnet-2.0.5-r1-gentoo.patch
	sed -i.orig -e"s:@@PF@@:${PF}:" Makefile
}

src_install() {
	# these directories aren't created during the make install
	# process, so we'll need to make them beforehand, or else
	# we'll have nowhere to put the files
	dodir /usr/{bin,lib,share} /usr/share/man/man1
	# install with make now
	make PREFIX=${D}/usr install web
	# install examples
        DOCDESTTREE=examples
	dodir /usr/share/doc/${PF}/${DOCDESTTREE}
	dodoc EXAMPLES/*
}

src_compile() {
	emake 
}



Reproducible: Always
Steps to Reproduce:




# ChangeLog for net-analyzer/cnet
# Copyright 2000-2003 Gentoo Technologies, Inc.; Distributed under the GPL v2
# $Header: /usr/local/portage/net-analyzer/cnet/RCS/ChangeLog,v 1.1 2003/12/05
03:19:56 root Exp $

*cnet-2.0.5-r1 (05 Dec 2003)

  05 Dec 2003; Bodrogi Viktor <[e-mail]>; cnet-2.0.5-r1.ebuild,
  files/cnet-2.0.5-r1-gentoo.patch:
  Installing documentation and examples.
  Added src_compile() to have compilation separated from installation.

*cnet-2.0.5 (01 Aug 2003)

  01 Aug 2003; Don Seiler <[e-mail]>; cnet-2.0.5.ebuild,
  files/cnet-2.0.5-gentoo.patch:
  Initial import. Thanks to Mike Gardiner <driver(at)iinet.net.au> for the
  original ebuild.

[Comment 1 viktor 2003-12-04 19:37:43 UTC]

The line:
S=${WORKDIR}/cnet-2.0.5
isn't necessary, delete it!

[Comment 2 Don Seiler (RETIRED) 2003-12-08 13:43:43 UTC]

The src_compile() function isn't needed.  It is automatically defined as emake and called.  You only need to define it if you need a compilation other than emake || die.

Also this won't merit a revision bump so I'll be putting the changes into the existing ebuild.

Also what is the point of the sed line in your unpack function?  I ran it and there was no diff between Makefile and Makefile.orig.

[Comment 3 Don Seiler (RETIRED) 2003-12-08 13:55:27 UTC]

Changes commited into portage.

[Comment 4 viktor 2003-12-09 05:11:08 UTC]

- Yes, it surely works without src_compile, but I had the experience that it does nothing when you do an ebuild ... compile. It works because src_install does `make install', which makes the project also. So compilation runs at installation time. Normaly you won't see the difference, it's just not nice like this. Am I worng with this?

- If it's not a new revision, how it will be updated on systems? Is it usual that ebuilds changes without new revision? It can make a lot of problem, doesn't it? If a file is different, it should be a new revision, IMHO.

- The sed line makes sense with my patch only, which I will attach now. Basicaly it changes the makefile doc installation target, not to install it into /usr/lib/...

[Comment 5 viktor 2003-12-09 05:13:41 UTC]

Created attachment 21920 [details, diff]
Patch for cnet-2.0.5-r1 ebuild.