Bug 35091 – Patches to make mplayer-1.0_pre2 compile with alsa 1.0 support

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description jack_mort 2003-12-04 14:23:35 UTC]

I'm switching from OSS to ALSA and so installed latest alsa ebuilds (1.0-rc1)
and launched a whole world recompilation.

While mplayer compiled fine, I found ALSA support was missing under the
"Preferences -> Audio". I recompiled another time and saw during configure, it
couldn't find ALSA headers.

Googling a bit gave me two patches from Mplayer mailing list.

For reference :
http://mplayerhq.hu/pipermail/mplayer-dev-eng/2003-November/022396.html

See attachements for an updated ebuild and the patches.

Reproducible: Always
Steps to Reproduce:
1. Install alsa 1.0-rc1
2. emerge mplayer
3.

Actual Results:  
No alsa output support.

Expected Results:  
Possiblity to get ALSA ouput.

Portage 2.0.49-r18 (default-x86-1.4, gcc-3.3.2, glibc-2.3.2-r9, 2.6.0-test11)
=================================================================
System uname: 2.6.0-test11 i686 AMD Athlon(tm) XP 2700+
Gentoo Base System version 1.4.3.12
ccache version 2.3 [enabled]
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -m3dnow -msse -mfpmath=sse -mmmx -O3 -pipe -fforce-addr
-funroll-loops -falign-functions=4 -maccumulate-outgoing-args -ffast-math
-fprefetch-loop-arrays"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-march=athlon-xp -m3dnow -msse -mfpmath=sse -mmmx -O3 -pipe
-fforce-addr -funroll-loops -falign-functions=4 -maccumulate-outgoing-args
-ffast-math -fprefetch-loop-arrays"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs buildpkg ccache fixpackages sandbox"
GENTOO_MIRRORS="ftp://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo
ftp://ftp.easynet.nl/mirror/gentoo ftp://gentoo.linux.no/pub/gentoo
ftp://ftp.fhh.opensource-mirror.de/pub/gentoo.org"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow X alsa apm avi berkdb bonobo cdr crypt cups dvd encode esd foomaticdb
gdbm gif gnome gpm gtk gtk2 gtkhtml imlib java jpeg libg++ libwww lirc mad
mikmod mmx mozilla mpeg ncurses nls oggvorbis opengl oss pam pdflib perl png
python quicktime readline samba sdl slang spell sse ssl svga tcpd truetype x86
xml2 xmms xv zlib"

[Comment 1 jack_mort 2003-12-04 14:26:06 UTC]

Created attachment 21712 [details, diff]
alsa-1.0-output.diff

First patch found on mplayer mailing list

[Comment 2 jack_mort 2003-12-04 14:27:06 UTC]

Created attachment 21713 [details, diff]
alsa-1.0-input.diff

Second patch found on mplayer mailing list

[Comment 3 jack_mort 2003-12-04 14:28:34 UTC]

Created attachment 21714 [details]
mplayer-1.0_pre2.ebuild

Updated ebuild

[Comment 4 Jeremy Huddleston (RETIRED) 2003-12-07 13:46:32 UTC]

Created attachment 21832 [details, diff]
trivial patch

Correct me if I'm wrong, but AFAIK, the 0.9.x and 1.0.x APIs are identical...
so the only thing that really needs to be fixed is the detection in
configure...

[Comment 5 jack_mort 2003-12-08 01:12:24 UTC]

Ok, your patch seems to be fine :-)

Guys at MPlayer mailing list are maybe a bit "too much" ^^

[Comment 6 Jeremy Huddleston (RETIRED) 2003-12-11 18:30:41 UTC]

actually, it looks like there are a few slight changes to the API, so it is probably best to use the other patch rather than have a bunch of special cases in there for the changed functions... it's mostly stuff like:

var = fun(a, b, c)

becoming

fun(a, b, c, &var)

[Comment 7 Martin Holzer (RETIRED) 2003-12-12 04:58:31 UTC]

i think pre3 fixes this

[Comment 8 jack_mort 2003-12-12 05:00:59 UTC]

Yes, I've just emerged pre3, and alsa support was compiled fine :-)

[Comment 9 Martin Holzer (RETIRED) 2004-01-03 07:49:37 UTC]

stable for stable, unstable for unstable

mplayer pre3 compiles with alsa 1.0