Bug 350635 – media-libs/gle-3.1.0-r1 please stabilize (was: 3.0.1-r2 fails to build with --as-needed)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Seemant Kulleen 2011-01-05 05:08:02 UTC]

The compile error:

gcc -O2 -march=nocona -pipe -fomit-frame-pointer -ftracer -Wall -Wl,-O1 -Wl,--as-needed -o beam beam.o mainsimple.o -lglut -lGLU -lGL -lgle -lXi -lXext -lXmu -lXt -lX11 -L../src/.libs -lm
../src/.libs/libgle.so: undefined reference to `gluTessVertex'
../src/.libs/libgle.so: undefined reference to `gluNewTess'
../src/.libs/libgle.so: undefined reference to `gluEndPolygon'
../src/.libs/libgle.so: undefined reference to `gluDeleteTess'
../src/.libs/libgle.so: undefined reference to `gluTessCallback'
../src/.libs/libgle.so: undefined reference to `gluBeginPolygon'
collect2: ld returned 1 exit status
make[2]: *** [candlestick] Error 1
../src/.libs/libgle.so: undefined reference to `gluTessVertex'
../src/.libs/libgle.so: undefined reference to `gluNewTess'
../src/.libs/libgle.so: undefined reference to `gluEndPolygon'
../src/.libs/libgle.so: undefined reference to `gluDeleteTess'
../src/.libs/libgle.so: undefined reference to `gluTessCallback'
../src/.libs/libgle.so: undefined reference to `gluBeginPolygon'
collect2: ld returned 1 exit status
make[2]: *** [beam] Error 1
make[2]: Leaving directory `/var/tmp/portage/media-libs/gle-3.0.1-r2/work/gle-3.0.1/examples'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/media-libs/gle-3.0.1-r2/work/gle-3.0.1'
make: *** [all-recursive-am] Error 2
emake failed

[Comment 1 Seemant Kulleen 2011-01-05 05:20:21 UTC]

This patch makes it compile ok:

--- gle-3.0.1-r2.ebuild.orig   2011-01-04 23:08:32.000000000 -0600
+++ gle-3.0.1-r2.ebuild 2011-01-04 23:16:14.000000000 -0600
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/media-libs/gle/gle-3.0.1-r2.ebuild,v 1.32 2010/09/16 17:13:03 scarabeus Exp $
 
-inherit eutils
+inherit eutils flag-o-matic
 
 DESCRIPTION="GL extrusion library"
 HOMEPAGE="http://www.linas.org/gle"
@@ -29,6 +29,7 @@
 }
 
 src_compile() {
+       append-ldflags $(no-as-needed)
        econf --with-x || die
        emake || die
 }

[Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) 2011-01-05 07:15:40 UTC]

There are no rdeps so this should be pretty straightforward. Arches please do you magic, thanks!

[Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) 2011-01-05 09:04:22 UTC]

sorry for the noise, I was too hasty. 3.1.0 has that bug too but it's well hidden

[Comment 4 Diego Elio Pettenò (RETIRED) 2011-01-05 15:43:07 UTC]

Seemant, to be clear, that patch would be wrong and just hide the problem under a rug; and would make anything linking to gle fail to link, because it's just going to tell ld "do link everything I tell you even if it's not used in the current executable", leaving libgle incomplete.

[Comment 5 Samuli Suominen (RETIRED) 2011-01-05 16:06:17 UTC]

seemant: Do you really need gle? It's been abandoned for 7 years, nothing in tree is using it, and the only package in tree that *could use it* is x11-misc/xscreensaver for one single saver (which only produces whitescreen and hardlockups machine)

I vote for lastriting gle altogether.

[Comment 6 Seemant Kulleen 2011-01-06 00:35:31 UTC]

Diego: understood.

Samuli: to be honest, I support last-riting the package, based on the facts you've indicated.  While I do need it, it doesn't have to live in the portage tree, when I can have it in the private overlay.

Thanks all!

[Comment 7 Kacper Kowalik (Xarthisius) (RETIRED) 2011-01-06 09:45:08 UTC]

# Kacper Kowalik <[e-mail]> (06 Jun 2011)
# Masked for removal in 30 days by QA request, abandoned by upstream 7 yrs ago, 
# bug #350635, no reverse dependencies in tree. Ebuild will be kept after
# removal in xarthisius' overlay
media-libs/gle

@seemant both patched versions are available in my overlay

[Comment 8 Tomáš Chvátal (RETIRED) 2011-02-10 11:42:15 UTC]

Treecleaned