Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 350616 - net-misc/openssh /proc/self/oom_adj needs to use /proc/self/oom_score_adj
Summary: net-misc/openssh /proc/self/oom_adj needs to use /proc/self/oom_score_adj
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://bugzilla.mindrot.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-05 01:25 UTC by Donald R. Gray Jr
Modified: 2011-01-08 22:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
oomkill patch (openssh-5.6_p1-linux-new-oomkill.patch,2.90 KB, text/plain)
2011-01-05 01:30 UTC, Donald R. Gray Jr 		Details
Updated ebuild (openssh-5.6_p1-r2.ebuild,7.70 KB, text/plain)
2011-01-05 01:30 UTC, Donald R. Gray Jr 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Donald R. Gray Jr 2011-01-05 01:25:15 UTC 
sshd ($PID) /proc/$PID/oom_adj is deprecated, please use /proc/$PID/oom_score_adj instead

Reproducible: Always
Comment 1 Donald R. Gray Jr 2011-01-05 01:30:10 UTC 
Created attachment 258887 [details]
oomkill patch
Comment 2 Donald R. Gray Jr 2011-01-05 01:30:44 UTC 
Created attachment 258888 [details]
Updated ebuild
Comment 3 Donald R. Gray Jr 2011-01-05 21:23:59 UTC 
Patch is from upstream, submitting here since I modified the ebuild to test the patch on a 2.6.36 kernel for upstream.
Comment 4 SpanKY gentoo-dev 2011-01-08 22:06:59 UTC 
your oom_adjust should be static and constant, and you should be using ARRAY_SIZE() instead of "2"

usually these sort of enhancements though go through the upstream project:
    https://bugzilla.mindrot.org/

it's not like the userspace abi is changing anytime soon here ...
Comment 5 SpanKY gentoo-dev 2011-01-08 22:07:47 UTC 
err, i see you already did.  i'll post my feedback there.