Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 34974 - emerge sync crashes with RSYNC_EXCLUDEFROM
Summary: emerge sync crashes with RSYNC_EXCLUDEFROM
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: High normal
Assignee: Portage team
URL:
Whiteboard:
Keywords:
: 36934 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-12-03 07:35 UTC by Nicolas Kaiser
Modified: 2011-10-30 22:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
change mycommand to rsynccommand for RSYNC_EXCLUDEFROM (emergeexclude.diff,689 bytes, patch)
2003-12-03 07:37 UTC, Nicolas Kaiser 		Details | Diff
updated patch (emerge-2.0.49-r19-excludefrom.patch,759 bytes, patch)
2004-01-01 07:12 UTC, Markus Luisser 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Kaiser 2003-12-03 07:35:57 UTC 
sys-apps/portage-2.0.49-r18

"emerge sync" crashes with "RSYNC_EXCLUDEFROM".

In /usr/bin/emerge, we're conditionally trying to append to "mycommand" in line
1754, while "mycommand" gets initialised in line 1797. Appending to
"rsynccommand" instead works as expected.
Patch attached.

Reproducible: Always
Steps to Reproduce:
1. mkdir /etc/portage
2. touch /etc/portage/rsync_excludes
3. RSYNC_EXCLUDEFROM="/etc/portage/rsync_excludes" emerge sync

Actual Results:  
Traceback (most recent call last):
  File "/usr/bin/emerge", line 1754, in ?
    mycommand=mycommand+" --exclude-from "+portage.settings["RSYNC_EXCLUDEFROM"]
NameError: name 'mycommand' is not defined

Expected Results:  
It should not have crashed.

Portage 2.0.49-r18 (default-ppc-1.4, gcc-3.2.3, glibc-2.3.2-r3, 2.4.21-ben2-grsec)
=================================================================
System uname: 2.4.21-ben2-grsec ppc 
Gentoo Base System version 1.4.3.12
ACCEPT_KEYWORDS="ppc ~ppc"
AUTOCLEAN="yes"
CFLAGS="-Os -pipe -mcpu=750 -fsigned-char -fomit-frame-pointer -ffast-math -W -Wall"
CHOST="powerpc-unknown-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3/share/config /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-Os -pipe -mcpu=750 -fsigned-char -fomit-frame-pointer -ffast-math -W
-Wall"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache sandbox"
GENTOO_MIRRORS="http://lucky"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://lucky/gentoo-portage"
USE="X aalib alsa apache2 apm avi berkdb bonobo cdr crypt cups dga directfb dvd
dvi encode esd fbcon foomaticdb gd gdbm ggi gif gnome gnome-libs gphoto2 gtk
gtk2 gtkhtml guile imlib jpeg lcms ldap libwww lua mbox mikmod mitshm motif
mozilla moznocompose moznoirc moznomail mozsvg mpeg mysql oggvorbis opengl oss
pam perl plotutils png pnp ppc python quicktime readline ruby ruby18 sdl slang
spell ssl tcltk tcpd tetex tiff truetype wmf xface xmms xv xvid zlib
video_cards_radeon"
Comment 1 Nicolas Kaiser 2003-12-03 07:37:47 UTC 
Created attachment 21637 [details, diff]
change mycommand to rsynccommand for RSYNC_EXCLUDEFROM
Comment 2 Marius Mauch (RETIRED) gentoo-dev 2003-12-03 08:53:42 UTC 
It's already fixed in CVS.
Comment 3 Jan Lam 2004-01-01 04:29:05 UTC 
In portage 2.0.49-r19 this bugs seems to be back.
Comment 4 Markus Luisser 2004-01-01 07:11:44 UTC 
ack

i get this error with portage-2.0.49-r19
Comment 5 Markus Luisser 2004-01-01 07:12:56 UTC 
Created attachment 22949 [details, diff]
updated patch
Comment 6 SpanKY gentoo-dev 2004-01-01 16:24:42 UTC 
*** Bug 36934 has been marked as a duplicate of this bug. ***